open-company / open-company-web Goto Github PK

I followed the instructions in the readme but got error after running lein figwheel:

Figwheel: Starting server at http://localhost:3449
Focusing on build ids: dev
Compiling "resources/public/js/compiled/open_company.js" from ["src"]...
Compiling "resources/public/js/compiled/open_company.js" failed.
clojure.lang.ExceptionInfo: failed compiling file:src/open_company_web/lib/devcards.cljs
 at clojure.core$ex_info.invoke (core.clj:4593)
Caused by: clojure.lang.ExceptionInfo: No such namespace: devcards.core, could not locate devcards/core.cljs, devcards/core.cljc, or Closure namespace "devcards.core"
 at clojure.core$ex_info.invoke (core.clj:4593)

clojure.lang.ExceptionInfo: No such namespace: devcards.core, could not locate devcards/core.cljs, devcards/core.cljc, or Closure namespace "devcards.core" {:tag :cljs/analysis-error}
    at clojure.core$ex_info.invoke(core.clj:4593)
    at cljs.analyzer$error.invoke(analyzer.cljc:562)
    at cljs.analyzer$error.invoke(analyzer.cljc:560)
    at cljs.analyzer$analyze_deps.invoke(analyzer.cljc:1668)
    at cljs.analyzer$ns_side_effects.invoke(analyzer.cljc:2504)
    at cljs.analyzer$analyze_STAR_$fn__2094.invoke(analyzer.cljc:2585)
    at clojure.lang.PersistentVector.reduce(PersistentVector.java:333)
    at clojure.core$reduce.invoke(core.clj:6518)
    at cljs.analyzer$analyze_STAR_.invoke(analyzer.cljc:2585)
    at cljs.analyzer$analyze.invoke(analyzer.cljc:2600)
    at cljs.analyzer$analyze_file$fn__2145.invoke(analyzer.cljc:2844)
    at cljs.analyzer$analyze_file.invoke(analyzer.cljc:2839)
    at figwheel_sidecar.repl$analyze_build.invoke(repl.clj:242)
    at figwheel_sidecar.repl$analyze_builds.invoke(repl.clj:247)
    at figwheel_sidecar.repl$run_autobuilder_helper.invoke(repl.clj:295)
    at figwheel_sidecar.repl$start_autobuild.invoke(repl.clj:366)
    at figwheel_sidecar.repl$run_autobuilder.invoke(repl.clj:576)
    at user$eval16475.invoke(form-init8571742883165147213.clj:1)
    at clojure.lang.Compiler.eval(Compiler.java:6782)
    at clojure.lang.Compiler.eval(Compiler.java:6772)
    at clojure.lang.Compiler.load(Compiler.java:7227)
    at clojure.lang.Compiler.loadFile(Compiler.java:7165)
    at clojure.main$load_script.invoke(main.clj:275)
    at clojure.main$init_opt.invoke(main.clj:280)
    at clojure.main$initialize.invoke(main.clj:308)
    at clojure.main$null_opt.invoke(main.clj:343)
    at clojure.main$main.doInvoke(main.clj:421)
    at clojure.lang.RestFn.invoke(RestFn.java:421)
    at clojure.lang.Var.invoke(Var.java:383)
    at clojure.lang.AFn.applyToHelper(AFn.java:156)
    at clojure.lang.Var.applyTo(Var.java:700)
    at clojure.main.main(main.java:37)
Subprocess failed

Any ideas what might happen?

Design a state for core topic placeholders to visual distinguish them from topic cards the user has started

Please update to the following:

div.fullscreen-topic button.remove-button {
left: 30px;
bottom: 30px;
}

The link generated in the share snapshot > share url modal is not working:

e.g. https://opencompany.comi.opencompany.com/companies/under-after/updates/april-2016-update-39b8

(Possibly not developed yet.. if so ignore)

When I shared a snapshot to Slack, I saw the "Sent" confirmation in the button on the share screen but no snapshot was shared to my team's slack account.

With carrot set to reach end of life in 2022, can we migrate to a licence that is intended to fully open source code? I would strongly suggest one of the OSI approved licences.

CC licences are super, but they are not intended for code. Very much horses for courses.

The share url button has an email icon in it implying email functionality, but it only gives you a link to copy and share manually. Swap in link icon instead of email icon on this button for ux clarity.

Requested on design priorities doc:

mobile nav bar size

@belucid can you provide a little more detail just so I'm clear on what you'd like me to check for this qa task?

"Learn More" link in footer links to opencompany.io. Expected behavior = links to opencompany.com

non-user content links: so… secondary links in a UI context

My email address was reported as incorrect because it finishes by .taipei.

.tw works, so I guess that there is a whitelist somewhere that may need an update - or maybe there shouldn't be a whitelist.

I spotted the problem in 2 places:

However, the validation problem did not prevent me from progressing through the registrations.

Provide page preloader

[Lower priority design qa item]

I successfully registered on open company instance on my computer, everything works well, as seeing the messages such as "sent verify to [email protected]" and authed [email protected], when I try to log in from front-end, it just redirects me back to the main page, after opening dev tools, I see i'm getting some errors, can anybody help me out with this, maybe it's a known issue and not relevant to my setup?
The error itself is

Uncaught Error: Doesn't support name: 
    at cljs$core$name (core.cljs:9391)
    at Function.cljs$core$IFn$_invoke$arity$1 (urls.cljs?rel=1545326245576:105)
    at oc$web$urls$org (urls.cljs?rel=1545326245576:100)
    at Function.cljs$core$IFn$_invoke$arity$1 (urls.cljs?rel=1545326245576:112)
    at oc$web$urls$all_posts (urls.cljs?rel=1545326245576:107)
    at oc$web$actions$user$login_redirect (user.cljs?rel=1545326252611:113)
    at Function.cljs$core$IFn$_invoke$arity$3 (user.cljs?rel=1545326252611:64)
    at oc$web$actions$user$entry_point_get_finished (user.cljs?rel=1545326252611:54)
    at user.cljs?rel=1545326252611:134
    at api.cljs?rel=1545326250922:247
    at api.cljs?rel=1545326250922:178
    at api.cljs?rel=1545326250922:141
    at oc$web$api$req_$_state_machine__20300__auto____1 (api.cljs?rel=1545326250922:141)
    at oc$web$api$req_$_state_machine__20300__auto__ (api.cljs?rel=1545326250922:141)
    at cljs$core$async$impl$ioc_helpers$run_state_machine (ioc_helpers.cljs?rel=1545326246373:35)
    at cljs$core$async$impl$ioc_helpers$run_state_machine_wrapped (ioc_helpers.cljs?rel=1545326246373:39)
    at ioc_helpers.cljs?rel=1545326246373:48
    at channels.cljs?rel=1545326246371:74
    at cljs$core$async$impl$dispatch$process_messages (dispatch.cljs?rel=1545326245684:19)
    at MessagePort.channel.port1.onmessage (nexttick.js:211)

When user initiates the "share a snapshot" flow, if they don't have many snapshots the placement/treatment of the footer draws too much attention and is distracting from the share ux.

A quick and easy fix is to add 400px to the bottom padding of div.topics-columns div.topics-column-container in the "share a snapshot" view so the footer is pushed down. Alternatively I'd suggest not displaying the footer here.

Screenshot of the issue:

Strongly recommend having a confirmation screen displayed after the user has shared to slack or email. Right now the only indication that something happened is the button language changes to "sent."

This makes it feel like the snapshot didn't go through. As a user, I'd expect to see a confirmation message e.g. "Your snapshot was sent via [Slack / email]." Return to dashboard (with link to your dashboard).

Screenshot of current confirmation screen:

Need design treatment for character count style on topic detail edit

Hi,

I'm run lein devcards! locally but couldn't see any results. Are the instructions accurate?

The carrot logo/watermark appears briefly, and then the screen is white:

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://ajax.googleapis.com/ajax/libs/jquery/2.1.4/jquery.min.js. (Reason: CORS request did not succeed).

leading of course to a $/JQuery not defined error.

Expected behavior:

1. If I'm on a company dashboard: https://opencompany.com/buffer and I
2. Click into a topic card, e.g. "We reached the 50.."
3. From the topic card I use the browser back button and
4. I return to the company dashboard

Observed behavior:

1. If I'm on a company dashboard: https://opencompany.com/buffer and I
2. Click into a topic card, e.g. "We reached the 50.."
3. From the topic card I use the browser back button
4. The company /profile is displayed and then
5. I return to the company dashboard

This is confusing because I didn't visit the profile in between, makes it feel like the back button is broken in the browser...

Suggestions:

1. Remove gold horizontal bar from below footer.
2. Have footer background color extend to bottom of page OR have footer positioned to bottom of page height.

Create H3 style for editing updates to enable H2 + H3 support

If you have any design suggestions of how the (+) would be less likely to be missed, we're all ears.

There's some difference in the options you're providing to users versus what was in the designs.

In designs:

In current build:

I'd suggest, from a design perspective, bold, h1, and h2 are the way to enable emphasis. I'd strongly suggest removing italic and strikethrough options. Strikethrough is visually crazy and will disrupt the reading experience.

Why not enable adding h1's?

Are inline imgs out of scope for now? Images are one of the few "hacks" that give people the ability to really customize and tell their stories visually.

Another is a busy state that works outside the yellow button. We used the “yellow button” busy in another place where we need a busy state and it looks pretty bad.

@belucid can you point me to where else you are using the busy state indicator (loading gif) outside of yellow buttons?

Verify font-size / spacing across the board

[Suggesting this is a lower-priority qa item]

While editing topic update, there's some strange ux with editing links.

Current Behavior

1. Select text, editing tools modal appears
2. Click to add link
3. Enter link url
4. Click elsewhere on the screen to close editing tools
5. Select some of the text within the hyperlinked text I just added
6. Click the link button again
7. Hyperlink removed, but only for the text I selected within the hyperlinked text

Expected behavior
... 7) Hyperlink removed entirely, for that whole hyperlinked text (see medium.com)