Git Product home page Git Product logo

opalimagepicker's People

Contributors

michal-olszewski avatar opalorange avatar rivera-ernesto avatar rlindner avatar snowzurfer avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

opalimagepicker's Issues

Unable to get external images from photo library

When i am selecting images from photo library it is showing to select images from local and external. But when i am selecting images from external images those are not loaded into my view.

Otherwise i want to remove selection from external library.
suggest me the solution.

Hide / Disable Segment Control for external Items

Hi,

i use your Picker and it works great. There is one last thing, that i can not solve.

I use your Picker like:
let imagePicker = OpalImagePickerController() imagePicker.imagePickerDelegate = self present(imagePicker, animated: true, completion: nil)

https://ibb.co/bLsoJ8

How can i hide or disable the Segment Control for external Items? I dont want to use external Items

Build errors

Unable to compile after pod update when we create a new project.

Unable to distinguish between images and videos in picker

With the current display method for videos in the picker (a single frame image) it is not possible to distinguish between an image and a video while picking assets. A simple icon like a play button, camera icon (like Photos.app), and/or video runtime overlaid across the image would go far towards usability.
Even further would be allowing this to be a configurable icon via OpalImagePickerConfiguration.

Live photos load slowly, can cause photos to become jumbled/out of order when scrolling quickly

I implemented this image picker into a project, and it was working great except for one customer with an iPhone 7. Photos were loading noticeably slowly for him. After some digging, I found that the slow-loading photos were mostly live photos, and he probably had over 1000 of them in total.

The slower loading times in turn were causing some issues with asynchronous loading and reusable views, causing photos to get mixed up, replaced, etc. Thankfully, the customer has recorded a video of the issue for me and has allowed me to share it here for you to look at:
scroll-bug.zip

Thanks for your work on this great library!

poor image quality

I am using 1.5.0 and when selecting images , it provides very poor image quality

Add support for custom albums?

It would be awesome to be able to add in custom image data (e.g. selecting pre-fetched Facebook photos to display in the OpalImagePicker). Let me know if this might be on the roadmap! :)

uncheck images

I use a OpalImagePicker in a viewcontroller for multil collectionview.
I want to uncheck images when present it again. please help me.

Album Picker

Not sure if this is the right place to put this, but is there any configuration to select the album?

Can't change the labels

Hi and thanks for the lib !

I can't change title for all the buttons done, cancel, title .. Did i miss something ?
Here is my code :

        let imagePicker = OpalImagePickerController()
        
        imagePicker.maximumSelectionsAllowed = 5
        imagePicker.configuration?.cancelButtonTitle = "Retour"
        imagePicker.configuration?.doneButtonTitle = "Valider"
        imagePicker.configuration?.navigationTitle = "Galerie"
        imagePicker.configuration?.okayString = "Ok"
        imagePicker.configuration?.maximumSelectionsAllowedMessage = "Vous pouvez sélectionner jusqu'à 5 médias de votre galerie !"
        
        presentOpalImagePickerController(imagePicker, animated: true, .....

Image size after selecting n number of images

I am having an issue like the image sizes are same for all the images that i select from the gallery and for all the images it is returning width = 282 and height =282. do i need to do some configuration settings to get the original image dimension for the images.

Unable to assign MediaTypes in Objective C

Hi,
I'm unable to set MediaTypes showing error Property 'allowedMediaTypes' not found on object of type 'OpalImagePickerController *'.

Code Smaple:
NSSet *mediaType = [NSSet setWithObject:[NSNumber numberWithInt:PHAssetMediaTypeImage]]; imagePicker.allowedMediaTypes = mediaType;

[ImageManager] Unable to load image data

Hi, I'm facing this warning [ImageManager] Unable to load image data, /var/mobile/Media/DCIM/100APPLE/IMG_0145.HEIC with IOS 11 + when i select the images the image picker get images thumbnails instead of the images, any ideas to solve this issue ?

Enabling 'Done' when no photos are selected || all photos are deselected

Hello Kristos!

Very nice Image Picker solution you've built for the world :)

Is there a particular reason as to why you have disabled the 'Done' button on your image picker when there are zero photos selected? I select photos, press done, it closes. But if I go back to the image picker, deselect the photos, I'm unable to press done. I see you're updating the done button's enabling on didSelectItemAt & didDeselectItemAt...

I would think that when you press Done -> It submits your changes and actions...
ex: Selection from 0 photos to 1 photo, saves with Done.
ex: Selection from 1 photo to 0 photos, saves with Done.

And when you press Cancel -> It doesn't submit any changes and actions you may have taken.
ex: Open with 0 photos, cancel, ending with 0 photos.
ex. Open with 1 photos, select 1 photo, cancel, end with 1 photo.
ex. Open with 0 photos, select 1 photo, cancel, end with 0 photos.

What do you think? If you're okay with me making these changes, I'll send in a pull request.

Ron

Done and Cancel buttons not visible

Hi,

Done and cancel buttons are not visible when I am implementing the same in my view controller.
Any specific reason for this.

I have been trying all the possible solution, but still no luck. Please do needful and suggest the solution for this.

Best,
Arvind

NSLocalizedString

How to change alert message when maximumSelectionsAllowed was exceed

Getting Double images in iOS 13

func imagePicker(_ picker: OpalImagePickerController, didFinishPickingAssets assets: [PHAsset]) {
presentedViewController?.dismiss(animated: true, completion: nil)
}

This method is retiring double images in assets array and it is working fine with iOS 12 or less, How can I fix this issue.

iphone 8 and above resoluton

Cannot convert value of type '(ImagePickerCollectionViewCell) -> (CGRect) -> CGRect' to type 'CGRect' in coercion with the latest plugin and iOS swift 3.x app

change title

hi i want to change the title and the two items (done, cancel) to another language how can i do this?
screen shot 2017-09-02 at 10 31 21 am

Using OpalImagePicker pod in objective-c project

Hey guys,

I would like to use OpalImagePicker as a cocopod in an objective-c project since you say in the description that it works with objective-c.

I installed the pod and tried to work with it by importing it:

#import "OpalImagePicker-Swift.h"

Here, I get a "file not found" error.

Does anyone know how to run this in objective-c?

(I use XCode version 9.4.1)

albums

albums selection support&?

EXIF meta data remove from Image

When i upload images on server using OpalImagePicker. Retrive same image from server and show in app then image not show properly as per gallery image. and there is no EXIF meta data in image.

So how can i solve problem?

Selection order

How are the selected images ordered? Are they randomly ordered?
Thanks,

Retrieve original size image

I am not able to extract original image size. The image gets resized when i debug it inside the delegate method. Any solution for this?

How to clear Previous images selection when present Picker?

In my scenario, i allow user to delete multiple images from selection and the issue is that when user delete single image from selected image and then when he present picker again all selected images are selected even deleted image is also selected so i want to clear previous selection when user present picker.

I have put below code in ViewDidLoad()

imagePicker.imagePickerDelegate = self
imagePicker.selectionTintColor = UIColor.black.withAlphaComponent(0.5)
imagePicker.selectionImageTintColor = UIColor.white
imagePicker.statusBarPreference = UIStatusBarStyle.lightContent
imagePicker.maximumSelectionsAllowed = 5
imagePicker.allowedMediaTypes = Set([PHAssetMediaType.image])

I think writing above code in UIButton action is bad idea as it takes too much memory if i write above code in UIButton action.

My Button Click Code.

@IBAction func btnSelectImageTapped(_ sender: UIButton) {
        self.present(imagePicker, animated: true, completion: nil)
}

so please let me know how can i clear images selection?

Thanks in advance.

carthage support

Thanks for the cool project. Is there any plan to support Carthage?

Thanks
Tianzhu

Don't display videos

I have integrated OpalImagePicker through cocoapods in my project.

I have several question regarding OpalImagePicker:

  1. When I present OpalImagePicker it is also displaying video thumbnail along with all images. So how can I restrict it. (Video mediaType=2/0 and in image mediaType=1/0)
  2. Is there any functionality for maximum selection?

Images Array Problem

Hello
I have a problem with the images array given in didFinishPickingImages function,
If I select one image, array count return 1, then I open Library again and I select a new image with the first one, array count return 3 instead of 2.

Thank you

Select albums

Hello, I haven't found how to select user albums already in photo app with OpalImagePicker, any info please ?

Seems it does not support deployment target 8.0

When I added pod 'OpalImagePicker' in podfile, I get error

Specs satisfying the OpalImagePicker dependency were found, but they required a higher minimum deployment target.

My App has deployment target as 8.0
Can you please advise if I can use with deployment target 8.0

How to get list of images without #delegate using , #presentOpalImagePickerController

Hello,

I am using without delegate method, so I want to know when I getting images list after the finish

here is my code please check

presentOpalImagePickerController(imagePicker, animated: true, select: { (assets) in
//Save Images, update UI

        //let getALLImg:[UIImage] = imagePicker.asset

// var i:Int = 0
// print(select)
// for getImage in select
// {
// print(i)
//
// switch i {
// case 0:
// self.img_view1.image = getImage
// case 1:
// self.img_view2.image = getImage
// case 2:
// self.img_view3.image = getImage
// default:
// print(i)
// }
// // print(getImage)
// i = i + 1
// }

        //Dismiss Controller
        imagePicker.dismiss(animated: true, completion: nil)
    }, cancel: {
        //Cancel action?
        
    })

Order of assets in completion handler

Can you let me know how the assets are being sorted when displayed in the completion handler? The image picker displays my images in date descending order but after I've picked them they come out in a different order which I can't quite work out (doesn't appear to be date ascending or descending). Ideally I'd like a way to specify image order (i.e. first image selected is first, second image selected is second, etc).

Thanks!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.