TitleTextColor not correctly set about multiline-collapsingtoolbar HOT 4 OPEN

Hi Steve,

thanks for the bug report. The reason for that is that we use TextPaint.setAlpha(int) in multiple places, which overrides the alpha value of the original collapsed/expandedTitleTextColor, but that should be quite easy to fix by multiplying the original alpha value to the value that is set there. The place you would need to look at is https://github.com/opacapp/multiline-collapsingtoolbar/blob/master/multiline-collapsingtoolbar/src/main/java/net/opacapp/multilinecollapsingtoolbar/CollapsingTextHelper.java#L487. The first part of the if-clause applies on Android 4.2 and below (which does not support hardware-accelerated text drawing, which means the text is saved as a texture instead) and the else part is for Android 4.3 and later, so probably both parts need to be adjusted.

If you need help, you can just ask here or via email at [email protected].

Please note that all modifications I made to the original Support Library code are marked with comments to simplify updating the code with later changes in the Support Library. So if you do adjustments, these should of course also be marked if they aren't already.

from multiline-collapsingtoolbar.

Thanks @johan12345!

I have not had a chance to do any testing on this but plan on in soon. I see the reason it is setup like that for the blending but will just need to test a bit.

It may be as easy as just extracting the alpha out of the textColors but I would imagine that will break or cause other things to go wrong.

I also took notice here (could be related to this issue): https://github.com/opacapp/multiline-collapsingtoolbar/blob/master/multiline-collapsingtoolbar/src/main/java/net/opacapp/multilinecollapsingtoolbar/CollapsingTextHelper.java#L336
...that setCollapsedTextBlend and setExpandedTextBlend are not in the if statement below.

Again thanks, and I will keep you updated on any progress.

from multiline-collapsingtoolbar.

Yes I same poblem

<style name="TextAppearance.ExpandedTitle"
    parent="TextAppearance.AppCompat.Widget.ActionBar.Title">
    <item name="android:textSize">26sp</item>
    <item name="android:textColor">@android:color/transparent</item>
</style>

Show title in black color when expanded, transparent = #00000000

from multiline-collapsingtoolbar.

@webserveis As written in the README, we can't spend much time to fix problems that don't occur in our app (we don't use transparent text there). I don't know if @codeversed is still working on fixing this, but if you want, you are welcome to try it too and send a Pull Request. I explained what needs to be adjusted in my post above.

from multiline-collapsingtoolbar.