Git Product home page Git Product logo

optee_website's Introduction

OP-TEE.org Static Jekyll Site

This is the git repository for OP-TEE's static Jekyll based website (OP-TEE.org).

Hosted in this repo are the markdown content files associated with the website. Feel free to submit a PR / Issue if there is anything you would like to change.

This static Jekyll site is using the jumbo-jekyll-theme. Please take a moment to review the guides on the theme's GitHub wiki.


Contributing

To make it easier to contribute to the content, Linaro provides a couple of Docker containers for building and checking the site. All you need is Docker installed on your computer and enough RAM and disc space.

To build the site:

cd <git repository directory>
./build-site.sh

To build the site and then serve it so that you can check your contribution appears:

cd <git repository directory>
JEKYLLACTION="serve" ./build-site.sh

To check that your contribution doesn't include any broken links:

cd <built web site directory>
../check-links.sh

The built web site directory will be production.op-tee.org.

For more information, please see the build container wiki and the link checker wiki.


Guides

Generic guides for Linaro static websites based on the jumbo-jekyll-theme:

optee_website's People

Contributors

afaerber avatar bfletcher avatar etienne-lms avatar jbech-linaro avatar jforissier avatar kylekirkby avatar morancj avatar pcolmer avatar philip-linaro avatar shovanco avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

optee_website's Issues

Broken links

There are a couple of broken links on the develop branch of the site:

2 failed links have been found:
/blog/op-tee-qa/index.html:
    https://www.op-tee.org/about/
/legal/index.html:
    https://www.op-tee.org/about/

As a reminder, links to itself should be relative and not absolute.

TEE_MACCompareFinal issue

Hello,

I am verifying the sign/verify operation of HMAC (sha2_256) using OPTEE-based linaro-kmgk keymaster.
There is a confusion in the verification process, so I ask for your opinion.

More specifically, it is an operation method of the TEE_MACCompareFinal function.

  • condition
    1/ algorithm: HMAC
    2/ digest: SHA2_256

  • Test process
    1/ generate key (192bit)
    2/ sign (mac length: 160bit)
    3/ verify

  • Result
    TEE_ERROR_MAC_INVALID

We confirmed that the test passed with the patch below.
However, we wonder why the truncated MAC is not being verified and what issue was there.

diff --git a/lib/libutee/tee_api_operations.c b/lib/libutee/tee_api_operations.c
index 4323e985..368fac56 100644
--- a/lib/libutee/tee_api_operations.c
+++ b/lib/libutee/tee_api_operations.c
@@ -1265,12 +1265,7 @@ TEE_Result TEE_MACCompareFinal(TEE_OperationHandle operation,
        if (res != TEE_SUCCESS)
                goto out;

-       if (computed_mac_size != macLen) {
-               res = TEE_ERROR_MAC_INVALID;
-               goto out;
-       }
-
-       if (consttime_memcmp(mac, computed_mac, computed_mac_size) != 0) {
+       if (consttime_memcmp(mac, computed_mac, macLen) != 0) {
                res = TEE_ERROR_MAC_INVALID;
                goto out;
        }

Thanks & Regards

Wording on index.md could be improved

Examples:

  • "ended up"
  • Sentence starting with "But before"
  • Sentence ending "etc."
  • Sentence starting with "A bit"
  • The whole sentence starting with "In 2015"
  • Another sentence starting with "But for"

I could attempt a rewrite suggestion in a PR, but I'm not a marketing guru. ๐Ÿ˜ƒ

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.