Don't have multiple dependency locations about atlantis-manager HOT 4 CLOSED

IIRC, the idea was that the manifest should specify required dependencies, so we can check that at deploy time instead of the running service mysteriously failing because dependencies don't exist.

On the other hand, the actual dependencies need to be set via Manager configuration, since they're environment-dependent.

So my instinct is that what we have now is actually a reasonable solution, unless we can somehow detect required dependencies from the application automatically. (This may actually be possible - we could require dependencies to be read via a special library that we could actually run at build time to determine required dependencies...)

from atlantis-manager.

I agree, this is a knee-jerk response to some debugging where teams forgot to add dependencies in the manifest. It took a bit to hunt this down, since the dependencies resolve correctly in the UI but were not available in the container.

How about we always resolve all dependencies as specified in the manager? After all have resolved, if there are any missing, we can refuse to deploy. I know you are going to say that this is no better: a dependency the application requires, but the developers missed adding in the manifest will cause different problems.

Perhaps a notification if there is a mismatch between dependencies in zk and in the manifest?

from atlantis-manager.

I know we (possibly Jigish and I) discussed adding warnings in the UI if dependencies exist in the manager but aren't in the manifest. I think that would resolve most issues in practice; we just haven't done it yet.

from atlantis-manager.

Good thing we have an issue for it now.

from atlantis-manager.