onshape-public / app-stl-viewer Goto Github PK

Wondering if I'm reading something wrong: on lines 97 and 117 of app.js, it appears that you are using the complete contents of passport.session() as a uniqueID key. Is this a bug?

​passport-onshape​ folder can be removed since the ​passport-onshape​ package is already being installed with npm.

Currently the /grantDenied URL is handled by using a bit of javascript to render a static page and return it as a response to the request.

This is a bit cumbersome and can be simplified by replacing :

app.get('/grantDenied', grantDenied.renderPage);

with

app.use('/grantDenied', express.static(path.join(__dirname, 'views', 'grantDenied.html')));

The grantDenied variable and the code it refers to can all be deleted.

A similar trick can be done for the app.get('/', index.renderPage);