Git Product home page Git Product logo

Comments (32)

jkasten2 avatar jkasten2 commented on July 20, 2024

Hello,

Can you confirm your testing on Android 4.1+ or later required for this feature? Also try swiping down on the notification, if there isn't enough room due to other notifications in the notification shade it will not be expanded by default.

Thanks.

from react-native-onesignal.

andreibarabas avatar andreibarabas commented on July 20, 2024

Hi,

Sure. Here are the specs:

Android 4.4.2

the app is built using

  • React Native 0.26
  • react-native-onesignal 1.1.4

As for the notification, here is the PREVIEW in OneSignal

screen shot 2016-06-02 at 09 27 19

and then, the result in the app. As you can see, there are no other notifications, AND I event tried pulling down, but no luck. Nothing happened.

screenshot_2016-06-02-09-32-52

P.S: other apps, like Whatsapp, Facebook, Gmail have similar buttons.

from react-native-onesignal.

jkasten2 avatar jkasten2 commented on July 20, 2024

Can you also check thetargetSdkVersion? It should be API Level 16 or higher.

from react-native-onesignal.

andreibarabas avatar andreibarabas commented on July 20, 2024

Sure. Here are the settings found in

android/app/build.gradle

    compileSdkVersion 23
    buildToolsVersion "23.0.1"

    defaultConfig {
        ...
        minSdkVersion 16
        targetSdkVersion 22
        ...
    }

Do you want me to try increasing the minSdkVersion to 17? but as long as the targetSdkVersion is 22, it shouldn't be a problem, no?

from react-native-onesignal.

andreibarabas avatar andreibarabas commented on July 20, 2024

I also tried bumping up the targetSdkVersion to 23, to match your build.gradle, but the same result. No action buttons :(

from react-native-onesignal.

avishayil avatar avishayil commented on July 20, 2024

Issue happens for me as well. We'll investigate it further.

from react-native-onesignal.

avishayil avatar avishayil commented on July 20, 2024

I updated the repo to the latest SDK and Google libraries but the issue still persist. @jkasten2

from react-native-onesignal.

andreibarabas avatar andreibarabas commented on July 20, 2024

I see. any luck with debugging the issue? Is there any way I can help?

from react-native-onesignal.

jkasten2 avatar jkasten2 commented on July 20, 2024

@avishayil @andreibarabas I haven't been able to reproduce an issue with our Android native SDK, I'll try out react-native to see if I can reproduce this.

from react-native-onesignal.

andreibarabas avatar andreibarabas commented on July 20, 2024

any luck replicating the issue? do you need some logs from my side?

from react-native-onesignal.

avishayil avatar avishayil commented on July 20, 2024

@jkasten2 can you guys help here?

from react-native-onesignal.

jkasten2 avatar jkasten2 commented on July 20, 2024

@andreibarabas @avishayil Can you send a link to a project and APK reproducing the issue? This will help me out as I work continue to work through some of the open issues on our Native Java SDK.

Thanks.

from react-native-onesignal.

andreibarabas avatar andreibarabas commented on July 20, 2024

@jkasten2 , I've sent you a repo invite. see branch push-notifications

from react-native-onesignal.

jkasten2 avatar jkasten2 commented on July 20, 2024

@andreibarabas Is there a pre-built APK in the repo? Can you send a link to one?

from react-native-onesignal.

jkasten2 avatar jkasten2 commented on July 20, 2024

@avishayil @andreibarabas Never mind, it seems the buttons only show up when a NotificationExtenderService is setup. I just created an issue to track this bug on the Native SDK side.
OneSignal/OneSignal-Android-SDK#61

Thanks.

from react-native-onesignal.

mizterp avatar mizterp commented on July 20, 2024

@jkasten2 Yep, took me hours to figure that bug out today

from react-native-onesignal.

jkasten2 avatar jkasten2 commented on July 20, 2024

@mizterp Thanks for reporting it!

I'll create a fix and get a release out for the issue this week yet.

from react-native-onesignal.

jkasten2 avatar jkasten2 commented on July 20, 2024

Just fixed this in release 2.4.3 along with another bug fix. It should be showing up in maven central in few hours and will be used as the default version.

from react-native-onesignal.

avishayil avatar avishayil commented on July 20, 2024

Thanks! will test it and report.

from react-native-onesignal.

andreibarabas avatar andreibarabas commented on July 20, 2024

Awesome! Will try it out

from react-native-onesignal.

avishayil avatar avishayil commented on July 20, 2024

I can confirm it's working.
Issue closed for now.

from react-native-onesignal.

andreibarabas avatar andreibarabas commented on July 20, 2024

@avishayil, @jkasten2 I even tried 1.1.8 ... the buttons do not appear :( i must be doing something wrong

from react-native-onesignal.

avishayil avatar avishayil commented on July 20, 2024

Can I see your server-side request?

from react-native-onesignal.

andreibarabas avatar andreibarabas commented on July 20, 2024

sure. I'm doing it from the Onesignal UI, and it's just like the screenshot

https://cloud.githubusercontent.com/assets/2101405/15735954/24976650-28a5-11e6-9764-6d3b6bd06a46.png

Or did you mean something else?

from react-native-onesignal.

andreibarabas avatar andreibarabas commented on July 20, 2024

I tried to CURL directly the API, and it works. This means that you have a bug in your OneSignal UI (unrelated to this repo).

Thanks!

from react-native-onesignal.

avishayil avatar avishayil commented on July 20, 2024

@jkasten2

from react-native-onesignal.

jkasten2 avatar jkasten2 commented on July 20, 2024

@andreibarabas Can you share the notification id? I can check it out on our server.

from react-native-onesignal.

andreibarabas avatar andreibarabas commented on July 20, 2024

76fc3ce6-e456-4f8d-bc65-ea3fed5ff7ae

P.S: I think you invoked some other user in your prev message

from react-native-onesignal.

jkasten2 avatar jkasten2 commented on July 20, 2024

@andreibarabas I am not able to reproduce an issue either. Can you try it again? Maybe the app wasn't rebuilt when you tested it at first? I can confirm your running the 2.4.3 native Android SDK code base now on your test device.

from react-native-onesignal.

andreibarabas avatar andreibarabas commented on July 20, 2024

@jkasten2 - I can confirm that if I'm using the API to send a push notification. it works (which is what I need). If I fire a notification from your UI, it does not :( (but that doesn't really matter, as I need the API). thanks

from react-native-onesignal.

mostafiz93 avatar mostafiz93 commented on July 20, 2024

@andreibarabas could you solve your issue?
I'm also trying to send notifications with buttons, but buttons are not appearing though notifications are being sent

from react-native-onesignal.

andreibarabas avatar andreibarabas commented on July 20, 2024

@mostafiz93 - yes. just make sure to use the latest SDK

from react-native-onesignal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.