Git Product home page Git Product logo

Comments (7)

Martinocom-Switcho avatar Martinocom-Switcho commented on August 22, 2024 2

I created an issue here some months ago: #1635
It was marked as resolved 8h ago so I hope new update will rollout soon!

from react-native-onesignal.

Martinocom-Switcho avatar Martinocom-Switcho commented on August 22, 2024 2

@Aya-Sato @pilotpirxie released
https://github.com/OneSignal/react-native-onesignal/releases/tag/5.2.1

from react-native-onesignal.

Aya-Sato avatar Aya-Sato commented on August 22, 2024 1

@Martinocom-Switcho Thank you for letting us know! I will close the issue

from react-native-onesignal.

Aya-Sato avatar Aya-Sato commented on August 22, 2024 1

@pilotpirxie @Martinocom-Switcho
Yes, I closed the issue because it was a duplicate. I do agree with @Martinocom-Switcho though that the original shouldn't have been closed if it was not released yet..

from react-native-onesignal.

pilotpirxie avatar pilotpirxie commented on August 22, 2024

I have the same issue and I had to do the ugly hack to quiet warnings and the error to support both platforms. On iOS it works fine, the object returned to the android device is invalid.

      if (
        oneSignalEvent.notification?.launchURL ||
        // eslint-disable-next-line @typescript-eslint/ban-ts-comment
        // @ts-expect-error
        oneSignalEvent.notification?.launchUrl
      ) {}

from react-native-onesignal.

pilotpirxie avatar pilotpirxie commented on August 22, 2024

@Aya-Sato Shouldn't you first release the fix and then close? When can we expect change to be released?

from react-native-onesignal.

Martinocom-Switcho avatar Martinocom-Switcho commented on August 22, 2024

@pilotpirxie I think it was closed because #1635 was still open and this was a duplicate.

But I agree that if merged ≠ released, the original #1635 should't be closed. Or at least it should be stated somewhere if this is the policy of this repo.

from react-native-onesignal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.