Comments (7)
I created an issue here some months ago: #1635
It was marked as resolved 8h ago so I hope new update will rollout soon!
from react-native-onesignal.
@Aya-Sato @pilotpirxie released
https://github.com/OneSignal/react-native-onesignal/releases/tag/5.2.1
from react-native-onesignal.
@Martinocom-Switcho Thank you for letting us know! I will close the issue
from react-native-onesignal.
@pilotpirxie @Martinocom-Switcho
Yes, I closed the issue because it was a duplicate. I do agree with @Martinocom-Switcho though that the original shouldn't have been closed if it was not released yet..
from react-native-onesignal.
I have the same issue and I had to do the ugly hack to quiet warnings and the error to support both platforms. On iOS it works fine, the object returned to the android device is invalid.
if (
oneSignalEvent.notification?.launchURL ||
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-expect-error
oneSignalEvent.notification?.launchUrl
) {}
from react-native-onesignal.
@Aya-Sato Shouldn't you first release the fix and then close? When can we expect change to be released?
from react-native-onesignal.
@pilotpirxie I think it was closed because #1635 was still open and this was a duplicate.
But I agree that if merged ≠ released, the original #1635 should't be closed. Or at least it should be stated somewhere if this is the policy of this repo.
from react-native-onesignal.
Related Issues (20)
- [Bug]: In v5, the Subscription Status does not change to 'Subscribed'. HOT 9
- [Bug]: permissionChange listener is not giving the correct hasPermission value until background/foreground HOT 3
- [question]: getIdAsync is returning null with latest SDK HOT 8
- [Bug]: Dependency problem while adding onesignal to an existing react native project HOT 5
- [Bug]: Incorrectly returning notification permission data until you close and open the app
- [question]: Even though I followed all the instructions, the icon does not change HOT 2
- [Bug]: Incorrect Typing for launchUrl in OSNotification HOT 1
- [Bug]: Erroneous "Usage Duration" for Android subscriptions in SDK 5.2.0 HOT 2
- [Feedback]: canRequestPermission should probably return false on Android versions < 13 HOT 1
- [Bug]: No type or protocol named 'OSUser' and 'OSLiveActivities' HOT 9
- [Bug]: Urgent Production OneSignal some users don't receive notifications HOT 4
- How to add jwtToken to login HOT 1
- [Bug]: Arrays on the additionalData not being parsed correctly on android HOT 1
- [Bug]: Subscription is not set in the dashboard after `OneSignal.login(externalId)` HOT 3
- [Bug]: OneSignal.Notifications.requestPermission returns a boolean wrapped in array instead of boolean on iOS HOT 2
- [Bug]: Setting `OneSignal.Notifications.requestPermission` parameter `fallbackToSettings` to `false` has no effect HOT 4
- [Bug]: OneSignalExtension No such module HOT 6
- [Bug]: App still receives notifications for the previous external ID if I call OneSignal.logout() and OneSignal.login() for other external ID HOT 1
- [question]: Best way to integrate OneSignal to subscribe VoIP push in another native module HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-onesignal.