Git Product home page Git Product logo

wolf3d's People

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

happy-ferret onixyara

wolf3d's Issues

incomplete logic of library usage

Generally, it's not an issue, but there is a way to improve this part of Makefile.

Technically you are assuming that if your system is linux then sdl2 is installed. It's not true for me and for many other linuxes:)

ifeq ($(OS), Linux)
CGFLAGS = `sdl2-config --cflags --libs` -lSDL2 -lSDL2_image -lSDL2_mixer -lSDL2_ttf -lm
else
CGFLAGS = -framework OpenGL -framework AppKit
INCLUDES =         -I./frameworks/SDL2.framework/Versions/A/Headers \
                              -I./frameworks/SDL2_ttf.framework/Versions/A/Headers \
		              -I./frameworks/SDL2_image.framework/Versions/A/Headers \
		              -I./frameworks/SDL2_mixer.framework/Headers \
		              -F./frameworks/
FRAMEWORKS = -F./frameworks \
			      -rpath ./frameworks \
			      -framework OpenGL -framework AppKit -framework OpenCl \
			      -framework SDL2 -framework SDL2_ttf -framework SDL2_image \
			      -framework SDL2_mixer
endif

Why not to use the library you are carrying with the project?

Personally, I see 2 different ways of Makefile improvement:

  • use a single local library for linux and mac-os
  • change a condition to something like:
ifneq ($(whereis libsdl2-dev), "") # test example, not tested

to make sure that lib is installed

Finally, it's not a bug or an issue, but a way of build process improvement.
Have a good day, thanks.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.