omaralbeik / userdefaultsstore Goto Github PK

The project has a 100% test coverage, however codecov is not working for some reason 😭
If you have an idea how to fix it, your help is highly appriciated

Add support to integrate into projects using Swift Package Manager

Based on the documentation in the readme, I got the impression that a laptop owned by a user came from the laptop store. Meaning that what was serialized to the store was the key to the laptop and that when I retrieved a user, it would also retrieve the laptop from the store.

What's actually happening is that the laptop is serialized into the data for the user. So if I were to say that John owned a MacBook and then changed the description of the MacBook in the laptop store, when I retrieved john's record, I would get the updated Macbook data. Instead, I get whatever was serialized when I saved john to the user store.

Does this make sense? I think it would be good to be explicit about what's happening, because I was getting inconsistency errors based on what I thought the docs were implying.

In inspecting the plist files that are created, I was surprised to see that they're not human readable, even though a JSONEncoder is being used. The issue is that you're taking the encoding and storing that directly, rather than converting it to a string.

I think it would be nice to have that at least as an option, to aid in debugging. To do so, you'd change save to look more like:

	public func save(_ object: T) throws {
		let data = try encoder.encode(object)
                if let str = String(data: json, encoding: .utf8) {
		     store.set(str, forKey: key(for: object))
		     increaseCounter()
                } else {
                     // throw appropriate error.
                }
	}

I'm sorry sir, my github account was suspended, I will now open it up pr again.

let cartSaved = UserDefaultsStore<CartItem>(uniqueIdentifier: "cart")

When I add the same product with the same id I want to increment the quantity but the saved cart (::allObject) method return me the same product

  var cart  = getCart()
        
        var targetItem  = cart.first(where: {$0.product.id == cartItem.product.id}) // <-- targetItem is a product in the [CartItem]
                
        
        if targetItem == nil  {
        
            print("prodct added ! ")
            cartItem.quantity += 1
            cart.append(cartItem)
            
            
        }else{
            
            targetItem?.quantity += 1
            
        }
        
        saveCart(cart: cart) // <--- here save again it should save the targetItem += 1

Cannot load package by SPM:
I have used:

".package(url: "https://github.com/omaralbeik/UserDefaultsStore.git", from: "1.4.0")

I have gotten:
`error: dependency graph is unresolvable; found these conflicting requirements:

Dependencies:
https://github.com/omaralbeik/UserDefaultsStore.git @ 1.4.0..<2.0.0`

After porting a bunch of code to work with UserDefaultsStore, I discovered that the "objects" you store can only be structs. It would be good to document this.

Looks dangerous.

Hash values are not guaranteed to be equal across different executions of your program. Do not save hash values to use during a future execution.

Would it be possible to add support to use iCloud through NSUbiquitousKeyValueStore instead of UserDefault ?