ollieday / lifx Goto Github PK

I got an exception today when trying to get GetStateAsync.
I asses this happend due line 75 in Communicator.
Will take further review later on.

Relevant part of stacktrace:
System.InvalidCastException: Unable to cast object of type 'Lifx.Communication.Responses.Payloads.ResponsePayload' to type 'Lifx.Communication.Responses.Payloads.StateResponsePayload'.
at Lifx.Communication.Communicator.CommunicateAsync[TResponsePayload](Request request, CancellationToken cancellationToken)
at Lifx.Light.GetStateAsync(CancellationToken cancellationToken)

I found an issue when trying to generate a light with an illegal IP. This can happen when there are non-bulbs, or network issues, and the attempt to create a Light fails.
It can be solved by test-catch on await communicator + new Light lines:

                try
		{
			var payload = await communicator
				.CommunicateAsync<StateVersionResponsePayload>(request, cancellationToken)
				.ConfigureAwait(false);
			
			light = new Light(address, payload.Product, payload.Version, communicator, requestFactory);
			return light;
		}
		catch (Exception ex)
		{
			communicator.Dispose();
			throw;
		}