ollidiemaus / autopotion Goto Github PK

looks like the wrong ID is being used.
272679 is the ID I have.
I do not know how to code. other than copy pasting C++ for mods. but yeah.
I appreciate your work here!

Since the sequence will always reset to the start, it doesn't make sense to use the cooldown of anything other than the first entry.
For example, if, as a druid, I have Renewal with 90s cd and then healthstone with 60s cd, the reset condition needs to be 90 and not 60.

With this behavior, the sequence will only reset if it can be used again.

The Retribution Paladin spec skill Light's Celerity makes Flash of Light instant with a 6 second cool down. If you can detect that talent, I think it would make a good addition to the priority list.

Just a suggestion to add to the list. I know you must be busy, but this would be a great help to all BM hunters. :) This macro is great and has vastly improved my survivability, I am about to go check out your other auto macro now and add it.

side note making one of these for defensive cool downs would be awesome. thank you from someone that is a reformed clicker!

While not as clear cut as #34, it would be useful to add the free Word of Glory's that can proc from Shining Light, when talented. ProtPal doesn't usually want to spend holy power of Word of Glory, so it doesn't necessarily belong in the list all the time, but when it's free I think it makes sense. Additionally, when talented into Bastion of Light, ProtPal gets three free WoGs or SotR when it's active, so it may make sense to add it in that case as well.

In a dungeon environment, resetting the sequence on combat will caue the macro to be less often useful, this can even cause wipes.
Instead, we could add a new checkbox "Only reset the sequence on cooldown" so the condition will be cd instead of combat/cd.

This isn't a bug, but can you provide a packaged release or upload to wag.io? Basically, when you release a version add a zip'd release along with the source files.

Thanks for your consideration. @

On my warlock and macro wont update,

still shows renewal from druid.

would be great to be able to customize the priority order of the healing sources, i.e.: when you want to use health potion first early on so it's available near the end of a fight

thanks.

Howdy, I've put forward a PR to address that WotLK is missing Runic Healing Injector in the list of potions. Please feel free to grab/ignore as you see fit!

#30

The Item table in WoW is used for loading and validating items for testing purposes. Your latest version of the addon overwrites the existing global table with a blank table before adding elements, here:

https://github.com/ollidiemaus/healthstoneAutoMacro/blob/main/Core/Item.lua#L1

I would recommend using a different able name or keeping your addon tables within your addon's namespace instead. Otherwise, this will break all other addons that use the Item table and/or taint the base UI when it looks for those item functions.

hey, tend to have this problem pretty often, and I assume you are aware/get many comments about it, however I need to mention it to make sure you are aware, and if there is anything I/you can do to help fix it.

I tend to get an issue where one of my abilities/potion/healthstone comes off cooldown, the macro does not reset, i.e will stay on the previously used item.

For example, I was doing some testing now and used "Renewal" it has come back off cooldown, yet auto potion is stuck on health potion, even through the priority should be to revert back to renewal? I assume this is something to do with the update checks of the addon?

It should be possible to preference pvp potions when in battlegrounds, which would be really handy.

Hey there,

I really love Auto Potion and would like to use it but I'm also using Mega Macro. The problem being that for some reason every time Auto Potion generates a updated Macro it just keeps spamming a new macro rather then over writing the current one.

This might be something more on the Mega Macro side but the developer isn't currently playing and I'm learning lua atm but not enough to investigate it thoroughly. Is there anything that can be done to bring these two great addons together?

@ollidiemaus or @malwhare
Hello there , great addon and everything but can we add like fail safe macro if i don't have anything of the Healthstone, Spiritual Healing Potion or Rejuventating Siphoned Essence to change macro to to something send messege to player to buy healing pot or get healthstones . because if i dont have anything and click the macro it give me error 

2x FrameXML\ChatFrame.lua:1028: Usage: CastSpellByName(name[, target])
[string "=[C]:"]: in function 'CastSpellByName'
[string "@FrameXML\ChatFrame.lua"]:1028: in function <FrameXML\ChatFrame.lua:956>
[string "@FrameXML\ChatFrame.lua"]:1233: in function '?'
[string "@FrameXML\ChatFrame.lua"]:5143: in function 'ChatEdit_ParseText'
[string "@FrameXML\ChatFrame.lua"]:4827: in function 'ChatEdit_SendText'
[string "@FrameXML\ChatFrame.lua"]:3075: in function <FrameXML\ChatFrame.lua:3068>
[string "=[C]:"]: in function 'UseAction'
[string "@FrameXML\SecureTemplates.lua"]:350: in function 'handler'
[string "@FrameXML\SecureTemplates.lua"]:663: in function <FrameXML\SecureTemplates.lua:607>
[string "=[C]:"]: ?
[string "@FrameXML\SecureHandlers.lua"]:266: in function <FrameXML\SecureHandlers.lua:263>
[string "=[C]:"]: ?
[string "@FrameXML\SecureHandlers.lua"]:296: in function <FrameXML\SecureHandlers.lua:279>
[string "=(tail call)"]: ?

Is it possible to add the racial skill Gift of the Naaru to the spells used?

It would be very nice to be able to combine healthstone and soulburn into the all in one button. It's very strong in both PvE and PvP.