Comments (9)
My pleasure! Crikey that is horrible. You're right.
Right, I'll take a look at this tomorrow and get back to you. Thanks for flagging
from onedarkpro.nvim.
@dstadelm - I don't know why but I used the fg_gutter
hl group for inactive lua lines. I think I was following a trend I saw with other themes but its naming doesn't make much sense. Either way, that is the group to override.
And...I had a ridiculously dark color set in the theme. It's lighter now. Let me know what you think
from onedarkpro.nvim.
Hi, that was quick!
Thanks now it is perfect.
I have some tweaks that you might be intrested in (taken from navarasu/onedark.vim)
The virtual text bothered me because it sometimes was indistinguishable from the actual content and I made following changes.
hlgroups = {
DiagnosticVirtualTextError = { fg = "#8b3434", bg = "#2a252b", style = "italic" },
DiagnosticVirtualTextWarn = { fg = "#835d1a", bg = "#292928", style = "italic" },
DiagnosticVirtualTextInfo = { fg = "#48b0bd", bg = "#25252b", style = "italic" },
DiagnosticVirtualTextHint = { fg = "#7e3992", bg = "#292534", style = "italic" },
},
Maybe you like it or it might give inspiration :-)
from onedarkpro.nvim.
Hi, that was quick!
The virtual text bothered me because it sometimes was indistinguishable from the actual content and I made following changes.
hlgroups = { DiagnosticVirtualTextError = { fg = "#8b3434", bg = "#2a252b", style = "italic" }, DiagnosticVirtualTextWarn = { fg = "#835d1a", bg = "#292928", style = "italic" }, DiagnosticVirtualTextInfo = { fg = "#48b0bd", bg = "#25252b", style = "italic" }, DiagnosticVirtualTextHint = { fg = "#7e3992", bg = "#292534", style = "italic" }, },
Maybe you like it or it might give inspiration :-)
Oh this looks interesting. Can you share a screenshot of it in action? It's a very good point actually. I think I just use the default colors for diagnostic warnings so it will blend in!
from onedarkpro.nvim.
How do these look?
Dark
Light
You can toggle underline and italic off with a new style I'm calling virtual_text
. Here I've set it to italic,underline
. I've created four new colors which take the value of red, yellow, blue and cyan and apply a lighten or darken effect (depending if you're in onelight or onedark). That way, if the user overrides a red, the virtual text still matches their customization.
from onedarkpro.nvim.
I'm not a big fan of underlines and in case of the virtual text even more so, but that is purely my subjective opinion.
This is what it looks with my mods
from onedarkpro.nvim.
Maybe the lightbulb should be purple :-) I didnt get around to that
from onedarkpro.nvim.
I just noticed this will not look as nice if the background isn't darkened like I've got it.
navarasu/onedark.vim has a function to darken the colors and also sets the background of the virtual text with some function, but I didn't quite understand how it is done. I'm not into lua yet to grasp things like that quickly.
from onedarkpro.nvim.
Yeah the underlines are off by default. Italics too. But easy to change in the config.
I'll play around with my settings and see how they look after some heavy usage 😉
from onedarkpro.nvim.
Related Issues (20)
- [Bug]: Custom queries override sane defaults HOT 2
- [Bug]: Can't override colors HOT 8
- Highlight DiffChange HOT 1
- [Bug]: missing comma in minimal config for bug reports
- [Bug]: @lsp.type.comment.lua overrides @text.uri.comment HOT 10
- [Bug]: Onedarkpro's highlights get overriden by typescript-language-server. HOT 15
- [Bug]: fixme/todos from comment parser overriden by semantic tokens in lua HOT 10
- Built-in linking takes precedence over the values set in the setup function HOT 2
- [Bug]: Very low contrast/unreadable text with light variant of the colorscheme HOT 11
- [Bug]: Error when setting `Comment` highlights (for the first time)? HOT 6
- [Bug]: Rust `#![attributes]` are not highlighted HOT 3
- [Bug]: onedark_dark floating panels indistinguishable HOT 8
- [Bug]: No Markdown Highlighting HOT 5
- [Bug]: lualine background has disappeared HOT 3
- [Bug]: missing treesitter-based highlight for JS/TS properties after breaking nvim-treesitter update HOT 5
- [Bug]: TS/TSX treesitter errors + broken syntax highlighting with onedark and latest nvim-treesitter HOT 6
- [Bug]: No highlight for selected complition in nvim-cmp with onedark_dark. HOT 4
- [Bug]: Change highlight on yank doesn't work. HOT 6
- [Bug]: Not an editor command: require("onedarkpro").setup HOT 3
- [Bug]: Transparent background not applied HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from onedarkpro.nvim.