Comments (8)
olimorris
commented on September 28, 2024
1
@chikko80 Can you check the latest commits. Not entirely sure what caused it but I could recreate it with the minimal.lua config.
from onedarkpro.nvim.
chikko80
commented on September 28, 2024
1
@olimorris Seems like its working, i'll test some things and if everything works as expected i'll close the issue - thanks so far
from onedarkpro.nvim.
olimorris
commented on September 28, 2024
1
@chikko80 completely with you! To take a few weeks away from the Neovim subreddit can feel like life has moved on 🤣.
I actually found I had very few warnings with 0.9/nightly compared with other versions. Might be some existing plugins need to be updated or have a separate branch for nightly.
Btw, was looking at the Rust filetype highlights last night. Think they're a little "off" compared to VS Code so will push some changes today. Appreciate your feedback on them.
from onedarkpro.nvim.
chikko80
commented on September 28, 2024
Most of it seems to work now but I am still facing the issue that I can't override @Keyword and @field.
For testing purposes i tried to highlight everything in white, but the @Keyword and @field doesn't work.
["@variable"] = { fg = "#FFFFFF", bg = "#FFFFFF"},
["@variable.builtin"] = {fg = "#FFFFFF", bg = "#FFFFFF"},
["@field"] = { fg = "#FFFFFF", bg = "#FFFFFF"},
["@keyword"] = { fg = "#FFFFFF", bg = "#FFFFFF"},
["@function"] = { fg = "#FFFFFF", bg = "#FFFFFF"},
["@function.builtin"] = { fg = "#FFFFFF", bg = "#FFFFFF"},
["@function.call"] = { fg = "#FFFFFF", bg = "#FFFFFF"},
["@function.macro"] = { fg = "#FFFFFF", bg = "#FFFFFF"},
["@method"] = { fg = "#FFFFFF", bg = "#FFFFFF"},
["@method.call"] = { fg = "#FFFFFF", bg = "#FFFFFF"},
["@constructor"] = { fg = "#FFFFFF", bg = "#FFFFFF"},
["@parameter"] = { fg = "#FFFFFF", bg = "#FFFFFF"},
["@type"] = { fg = "#FFFFFF", bg = "#FFFFFF"},
["@type.builtin"] = { fg = "#FFFFFF", bg = "#FFFFFF"},
["@type.definition"] = { fg = "#FFFFFF", bg = "#FFFFFF"},
["@type.qualifier"] = { fg = "#FFFFFF", bg = "#FFFFFF"},
["@storageclass"] = { fg = "#FFFFFF", bg = "#FFFFFF"},
["@attribute"] = { fg = "#FFFFFF", bg = "#FFFFFF"},
["@property"] = { fg = "#FFFFFF", bg = "#FFFFFF"},
--
--
["@constant"] = {fg = "#FFFFFF", bg = "#FFFFFF"},
["@constant.builtin"] = {fg = "#FFFFFF", bg = "#FFFFFF"},
["@constant.macro"] = {fg = "#FFFFFF", bg = "#FFFFFF"},
["@namespace"] = {fg = "#FFFFFF", bg = "#FFFFFF"},
["@symbol"] = {fg = "#FFFFFF", bg = "#FFFFFF"},
["@definition"] = {fg = "#FFFFFF", bg = "#FFFFFF"},
["@definition.constant"] = {fg = "#FFFFFF", bg = "#FFFFFF"},
["@definition.function"] = {fg = "#FFFFFF", bg = "#FFFFFF"},
["@definition.method"] = {fg = "#FFFFFF", bg = "#FFFFFF"},
["definition.var"] = {fg = "#FFFFFF" , bg = "#FFFFFF"},
["@definition.parameter"] = {fg = "#FFFFFF", bg = "#FFFFFF"},
["@definition.macro"] = {fg = "#FFFFFF", bg = "#FFFFFF"},
["@definition.type"] = {fg = "#FFFFFF", bg = "#FFFFFF"},
["@definition.field"] = {fg = "#FFFFFF", bg = "#FFFFFF"},
["@definition.enum"] = {fg = "#FFFFFF", bg = "#FFFFFF"},
["@definition.namespace"] = {fg = "#FFFFFF", bg = "#FFFFFF"},
["@definition.import"] = {fg = "#FFFFFF", bg = "#FFFFFF"},
["@definition.associated"] = {fg = "#FFFFFF", bg = "#FFFFFF"},
from onedarkpro.nvim.
olimorris
commented on September 28, 2024
Can you share your example file and try :OnedarkproCache. There's no reason for some to work and others not to so really strange,
from onedarkpro.nvim.
chikko80
commented on September 28, 2024
Tried :OnedarkproCache but didn't help
just drop this example rust code in a rest.rs file
pub struct Test{
test: String,
test2: String,
}Looks like this:
from onedarkpro.nvim.
olimorris
commented on September 28, 2024
That is expected. If I run the :Inspect command I see:
- For
test:
- For
String:
This is because you have the filetype highlighting for Rust turned on by default and it has a separate entry for ["@field.rust"] which overwrites the ["@field"] that would be applied to Rust normally without filetype highlighting. You can turn this off by:
filetypes = {
rust = false,
}from onedarkpro.nvim.
chikko80
commented on September 28, 2024
Oh okay got it sorry. Just learning all these new plugins currently and it's a bit overwhelming.
But tbh Neovim 0.9 with the lsp semantics comes the closest to vscode and I even customized semantic tokens in my VSCode so it fits perfectly.
Currently if I run Neovim 0.9 with treesitter i'll get a bunch of warnings. Is this expected since 0.9 is only on nightly available right now? Did you already migrate your personal setup to 0.9?
from onedarkpro.nvim.
Related Issues (20)
- Cursor line changes the highlight of folded text. HOT 3
- different token color for constant variables (just like vscode) HOT 7
- Enhancement: Custom Treesitter queries HOT 21
- Transparency not working with iTerm2 on macOS HOT 1
- [Bug]: Custom queries override sane defaults HOT 2
- Highlight DiffChange HOT 1
- [Bug]: missing comma in minimal config for bug reports
- [Bug]: @lsp.type.comment.lua overrides @text.uri.comment HOT 10
- [Bug]: Onedarkpro's highlights get overriden by typescript-language-server. HOT 15
- [Bug]: fixme/todos from comment parser overriden by semantic tokens in lua HOT 10
- Built-in linking takes precedence over the values set in the setup function HOT 2
- [Bug]: Very low contrast/unreadable text with light variant of the colorscheme HOT 11
- [Bug]: Error when setting `Comment` highlights (for the first time)? HOT 6
- [Bug]: Rust `#![attributes]` are not highlighted HOT 3
- [Bug]: onedark_dark floating panels indistinguishable HOT 8
- [Bug]: No Markdown Highlighting HOT 5
- [Bug]: lualine background has disappeared HOT 3
- [Bug]: missing treesitter-based highlight for JS/TS properties after breaking nvim-treesitter update HOT 5
- [Bug]: TS/TSX treesitter errors + broken syntax highlighting with onedark and latest nvim-treesitter HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from onedarkpro.nvim.