Add filetype specific highlight groups about onedarkpro.nvim HOT 6 CLOSED

Thanks for the fixes! I've confirmed that I can't reproduce those bugs anymore.

Here's what I'm seeing now, using the same test config as before:

  hlgroups = {
    TSFunction = {fg = "${orange}"},
  },
  filetype_hlgroups = {
    yaml = {
      TSField = { fg = "${red}" },
    },
    javascript = {
      TSFunction = { fg = "${green}" },
    },
    php = {
      TSFunction = { fg = "${purple}" },
    },
    ruby = {
      TSFunction = { fg = "${blue}" },
    }
  },

First, syntax highlighting in Telescope's preview uses the highlight groups of the filetype in the buffer that was open when Telescope was called rather than the filetype of the file being previewed.

For example:

• Given a JavaScript hlgroup that sets the TSFunction fg to green
• And a Ruby hlgroup that sets the TSFunction fg to red
• When I open a JS file
• And then I open the Telescope file finder and preview a Ruby file
• The function names in the preview window should be red, but are actually green

Demo:

Second, if I switch to a buffer that uses the non-file-type-specific hl group (the orange one, above), and then back to one that matches a rule for a specific file type (e.g., PHP), the PHP file will use the generic color instead of the PHP color. If I then switch to a file that has a specific rule (e.g., JS) and back to PHP, the correct colors are shown.

Demo:

from onedarkpro.nvim.

@mmirus I've fixed the two issues you spotted in the latest commit. Please let me know what you think.

The solution to the floating windows was to ignore specific filetypes and buffer types.

from onedarkpro.nvim.

That is some epic testing! Thanks so much. I shall see if I can resolve!

from onedarkpro.nvim.

Struggling to solve the Telescope previewer issues. Will open an issue on their side and ask for help. Seems Telescope reads the file asynchronously with vim.loop.fs_ and there is no way to detect when you preview a ruby then a js file.

Key question: how much of a nuisance would it be for you?

from onedarkpro.nvim.

You got it!

from onedarkpro.nvim.

It probably wouldn't be much of an issue initially, as I don't have many file type specific rules in mind. If that grew over time then it would become more likely for the preview to differ significantly in projects with multiple languages.

From my perspective it's a matter of preference for you if it's a blocker or not. Waiting to add the feature means folks have to accept the trade-off of not being able to do file type specific rules. Releasing it with this bug means they can choose whether they prefer limited highlighting or buggy previewing. Of course that could open you up to complaints. So it's just down to what you want to do!

from onedarkpro.nvim.