vscode onedarkpro vs this one about onedarkpro.nvim HOT 13 CLOSED

Firstly, thank you for your detailed feedback and config. It is greatly appreciated.

I agree with the majority of your changes and have addressed them in the latest commit. Some I have not included (detail and reasoning below).

The onedarkpro for vscode is adding unique style for each language. IMO, this repo should do the same.

Yes it does. I have actively thought about doing this and may look into it in the near future. Let me know if you make any progress. Always open to pull requests.

FYI, the hlgroups which I have kept the same are:

TSRepeat
Operator
Special

Reason being that they caused some difference in look between Neovim and VS Code in Ruby, Python and Javascript files which I don't have with their current values. Happy to be corrected and adjust them (could always be a setting I missed in my custom VS Code config).

But please let me know your thoughts on the changes. I've updated the readme screenshots too.

from onedarkpro.nvim.

Thanks both! I was able to remove a few of my customizations after updating.

I did prefer TSConstBuiltin = { fg = theme.colors.orange }, over the purple, though. See the end of the second line for why:

vs

from onedarkpro.nvim.

@mmirus, you sir, are a legend as always! Thanks for spotting

from onedarkpro.nvim.

Thanks for the feedback.

Could you let me know the highlights and colors that you've changed and I'll look into incorporating into the theme.

Regarding the italics, I'll caveat by saying in the readme I specify "Use the themes opinionated italic styles?" but there is a case for setting this to false by default.

from onedarkpro.nvim.

local colors = require("onedarkpro").get_colors("onedark")
...

colors = { 
   bg = "#282c34"
},


hlgroups = { 
   -- onedarkpro -> treesitter.lua plugin
   TSInclude = { fg = colors.purple, style = "NONE" },
   TSTypeBuiltin = { fg = colors.yellow },
   TSConstBuiltin = { fg = colors.purple },
   TSConstructor = { fg = colors.yellow },
   TSRepeat = { style = "NONE" },
   TSFuncMacro = { fg = colors.blue },
   TSParameterReference = { fg = colors.red },

   -- onedarkpro -> theme.lua
   Include = { fg = colors.purple },
   Function = { fg = colors.blue },
   Operator = { fg = colors.fg }, 
   Macro = { fg = colors.blue },
   Special = { fg = colors.fg },
   Structure = { fg = colors.purple },
   Identifier = { fg = colors.red },
   Typedef = { fg = colors.purple },
   Constant = { fg = colors.orange },
 }

Results:

• Rust
  nvim
  
  vscode
  

• C
  nvim
  
  vscode
  

• C#
  nvim (The first in red is annoying. It should be yellow but TSVariables set it to red)
  
  vscode
  

• Go
  nvim (the functions in the interface are in red)
  
  vscode
  

• Typescript is ok

• Javascript is not

The onedarkpro for vscode is adding unique style for each language. IMO, this repo should do the same.
For now, I'm trying to add custom highlighters with treesitter/playground.
Nice work BTW.

from onedarkpro.nvim.

bde2f18#diff-6278de756e40002a1404b733de0b7f2d1526f9fd53e80f01b4aff117ac98e17dR112

@olimorris Typo here, I think 😉

Edit: also bde2f18#diff-6278de756e40002a1404b733de0b7f2d1526f9fd53e80f01b4aff117ac98e17dR93

from onedarkpro.nvim.

bde2f18#diff-6278de756e40002a1404b733de0b7f2d1526f9fd53e80f01b4aff117ac98e17dR112

@olimorris Typo here, I think 😉

Edit: also bde2f18#diff-6278de756e40002a1404b733de0b7f2d1526f9fd53e80f01b4aff117ac98e17dR93

I can't see where the typos are in the diff. In the readme?

from onedarkpro.nvim.

Maacro and Faunction in theme.lua:

from onedarkpro.nvim.

You got it!

from onedarkpro.nvim.

Ok for the highlights but the plugins are somehow always set to true event I change it to false.

This is not working:

   all = false,
   packer = true,
   treesitter = true,

or this

   packer = false,
   treesitter = false,

from onedarkpro.nvim.

Should now be fixed. I've had to apply some trickery to how we merge the default config with the user's custom config. End result is your test cases above now work.

from onedarkpro.nvim.

@sinkyl - Would you also be willing to try out the filetype_hlgroups branch?

I've got a WIP feature which allows you to add custom highlight groups for specific filetypes. Works great on my end (to overcome the TSField issue with yaml files) but keen to see your use cases and especially if you notice any performance issues.

from onedarkpro.nvim.

All good now.
I'll give a try later.
Thx 💯

from onedarkpro.nvim.