Git Product home page Git Product logo

Comments (12)

erancx avatar erancx commented on June 25, 2024 1

I just updated to latest version, still not working.
My config can be found here (just copied it over from your config.

YAML is nice to have feature but obviously not urgent at all :)

I'll look at https://github.com/RRethy/nvim-base16 and add Onedarkpro to that repository.

Again, amazing work dude!

from onedarkpro.nvim.

erancx avatar erancx commented on June 25, 2024 1

I just changed colorscheme and I'm still having the same behavior.

Let me debug that and report back here

from onedarkpro.nvim.

olimorris avatar olimorris commented on June 25, 2024

So glad you're enjoying it!

It seems like indent blankline is not colored when you hover on it.

So I've tried to get this to work in my own config. I can't seem to at all. Can you share yours? Also, you can override/create hlgroups with the theme. I have a tonne in my own dotfiles.

Also, YAML keys are not highlighted (is this expected behavior?)

Ah yes. I've been waiting for someone to bring this up. In order to closely match the VS Code version of One Dark Pro I had to make some compromises in the theme regarding treesitter hlgroups. One of them massively affected how a yaml file looks. The exact one I can't remember now. I wonder if I can fix this with a FileType auto command... 🤔 . Leave it with me.

Last but not least, can this be supported with base16?

Hmmmm. Not sure how I do this. I have defined the base colors here and you can technically call them with the (undocumented) terminal_colors option in the config. Can you let me know how other theme's do this or what settlings you apply to achieve this? Is termguicolors off?

from onedarkpro.nvim.

olimorris avatar olimorris commented on June 25, 2024

It seems like indent blankline is not colored when you hover on it.

Please try the latest commit. This should be fixed.

If you don't like the choice of purple then you may override the IndentBlanklineContextChar hlgroup. It has to be purple, though, right? 😉

Screen Shot 2021-11-25 at 17 40 13@2x

Sorry, had to obfuscate the code in that screenshot

from onedarkpro.nvim.

erancx avatar erancx commented on June 25, 2024

I enabled show_first_indent_level on indent line and I can see the first line is a static purple color but if you hoover to other levels it won't color it

from onedarkpro.nvim.

olimorris avatar olimorris commented on June 25, 2024

I enabled show_first_indent_level on indent line and I can see the first line is a static purple color but if you hoover to other levels it won't color it

Hmmm. By enabling show_current_context and show_current_context_start, this is what I get:

Screen Shot 2021-11-25 at 18 17 41

Perhaps I'm misunderstanding. What about if you overwrite the hlgroups for the plugin?

from onedarkpro.nvim.

olimorris avatar olimorris commented on June 25, 2024

YAML is nice to have feature but obviously not urgent at all :)

It has bothered me for some time. I'm going to open it as it's own issue and see if I can resolve it at a later point in time

from onedarkpro.nvim.

erancx avatar erancx commented on June 25, 2024

I have both show_current_context and show_current_context_start and still only the first level is being colored.
What should I set with hlgroups?

What version of Neovim do you use?

from onedarkpro.nvim.

olimorris avatar olimorris commented on June 25, 2024

Weird. I am using 0.5.1. Do you have use_treesitter enabled too?

I'm actually using the default hlgroups in the theme now

from onedarkpro.nvim.

erancx avatar erancx commented on June 25, 2024

yeah, I have use_treesitter enabled here.

is there any way to increase debug mode to view some additional settings?

from onedarkpro.nvim.

erancx avatar erancx commented on June 25, 2024

Here's an example

asciicast

from onedarkpro.nvim.

olimorris avatar olimorris commented on June 25, 2024

I just changed colorscheme and I'm still having the same behavior.

Bizzarely, I deleted the plugin and reinstalled it. No idea why that worked I don't believe it caches anything, but it did solve it.

from onedarkpro.nvim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.