"Vivid" colors about onedarkpro.nvim HOT 13 CLOSED

As an FYI both, I've now added a onedark_vivid them as per this commit:

require("onedarkpro").setup {
  theme = "onedark_vivid",
}

from onedarkpro.nvim.

I've closed this and pinned it to the top of issues so it will stand out more to other users

from onedarkpro.nvim.

It seems that is the case. I did a bunch of testing and it does work but does not persist. I seemingly have to change :colorscheme back (to a different theme) and forth to see the custom setup, otherwise it defaults to the default setup values. It was hard to tell because quitting and relaunching Lunarvim didn't change the outcome, also TS-rainbow seems to get disabled.

Thanks again for your help. It's definitely related to my setup so I'll look to find a solution.

Config

Outcome

from onedarkpro.nvim.

I thought I'd put this here in case a search engine brings someone to this issue.

I solved it. It was more my misunderstanding of the structure of LunarVim's config files and Lua.

The setup needs to be added outside the scope of lvim.plugins to persist.

--[[
lvim is the global options object

Linters should be
filled in as strings with either
a global executable or a path to
an executable
]]
-- THESE ARE EXAMPLE CONFIGS FEEL FREE TO CHANGE TO WHATEVER YOU WANT

-- general
lvim.log.level = "warn"
lvim.format_on_save = true
-- lvim.colorscheme = "one"
-- lvim.colorscheme = "onedarker"
lvim.colorscheme = "onedarkpro"


-- Theme options
require("onedarkpro").setup {
  theme = "onedark",
  -- colors = {
  --   red = "#d1d1d1"
  -- },
  styles = {
    functions = "italic",
    keywords = "italic",
    virtual_text = "italic,underline",
  },
}

from onedarkpro.nvim.

Thank you!

from onedarkpro.nvim.

Hi @olimorris I'm fairly new to nvim and Lua and looking to change the color of "variables" (assigned) in my config and I'm not sure how. I've tried;

  { "olimorris/onedarkpro.nvim",
    config = function()
      require("onedarkpro").setup {
        theme = "onedark",
        colors = {
          red = "#97f4c9"
        },
      }
    end
  },

..but couldn't get it to work. What am I missing?

from onedarkpro.nvim.

..but couldn't get it to work. What am I missing?

Have you tried this at the end of your config:

onedarkpro.load()

from onedarkpro.nvim.

I'm using Lunarvim and I believe it loads the plugin. It also shows that it is installed in PackerStatus.

I have also tried to add the function call in my config;

It unfortunately still doesn't change the red variable colour in my code.

from onedarkpro.nvim.

Hmmmm. Seems strange. Have you tried adding @mmirus config specifically like below:

local onedarkpro = require('onedarkpro')
onedarkpro.setup({
theme = "onedark",
colors = {
onedark = {
-- Vivid colors from https://github.com/Binaryify/OneDark-Pro
red = "#ef596f",
green = "#89ca78",
cyan = "#2bbac5",
purple = "#d55fde",
},
}

If you nest a onedark table within the colors table. That shouldn't actually make a difference but good to rule it out.

Otherwise, I suspect another theme or option is overwriting the TSVariable highlight group (assuming you're using Treesitter). What does :hi TSVariable show?

from onedarkpro.nvim.

Nesting onedark does not change the colors.

I am using Treesitter, :hi TSVariable shows TSVariable xxx guifg=#e06c75. This is using mmirus’ config.

I also tried disabling all other additional plugins to no avail.

I’ll keep trying to sort it out, I now have a better understanding of how Treesitter works. Thank you!

from onedarkpro.nvim.

I'm at a loss to explain it other than there must be something, somewhere in your config which is not applying the change. Are you sure LunarVim is definately applying the theme?

I've just tried it in my config and this is the outcome:

Config

Outcome

from onedarkpro.nvim.

Very cool--thank you! I was able to replace my vivid overrides with dark_theme = "onedark_vivid" and my remaining onedark overrides (unrelated to making things more vivid) kept working.

It may be counterintuitive, but I may go back to the darkened versions of the virtual text. 2f931d2#diff-708b067690c963ab0c5a4dec1eb8f6c0e1f7cda3a447538280b3bde6cd7ffb47 I kind of like having the diagnostic info fade into the background a bit--readable when I need it, but not competing with the code for attention.

I can see other people wanting the opposite, though: "If there's a diagnostic, I want it to be yelling for attention so I deal with it right away."

from onedarkpro.nvim.

Awesome! Still a little bit of work I need to do on the internal API to add new themes but mostly there

from onedarkpro.nvim.