oleggulevskyy / better-ts-errors.nvim Goto Github PK

View Code? Open in Web Editor NEW

110.0 110.0 5.0 5.43 MB

License: MIT License

Makefile 3.48% Lua 88.14% Shell 8.38%

better-ts-errors.nvim's People

Contributors

Stargazers

Watchers

Forkers

nullvoxpopuli jamescdavis andrew-t-james-core icholy rayguo-ergou

better-ts-errors.nvim's Issues

Crashing when trying to view an error

Description

   Error  15:11:37 msg_show.lua_error E5108: Error executing lua ...b/.local/share/nvim/lazy/nui.nvim/lua/nui/utils/init.lua:29: Invalid window id: 1000
stack traceback:
	[C]: in function 'nvim_win_get_width'
	...b/.local/share/nvim/lazy/nui.nvim/lua/nui/utils/init.lua:29: in function 'get_window_size'
	....local/share/nvim/lazy/nui.nvim/lua/nui/layout/utils.lua:94: in function 'get_container_info'
	....local/share/nvim/lazy/nui.nvim/lua/nui/layout/utils.lua:161: in function 'update_layout_config'
	...b/.local/share/nvim/lazy/nui.nvim/lua/nui/popup/init.lua:388: in function 'update_layout'
	...azy/better-ts-errors.nvim/lua/better-ts-errors/popup.lua:25: in function 'show'
	...tter-ts-errors.nvim/lua/better-ts-errors/diagnostics.lua:138: in function 'show'
	...lazy/better-ts-errors.nvim/lua/better-ts-errors/main.lua:31: in function 'toggle'
	...lazy/better-ts-errors.nvim/lua/better-ts-errors/init.lua:11: in function 'toggle'
	[string ":lua"]:1: in main chunk

Steps to reproduce

<leader>dd on an error in a svelte file

Expected behaviour

The UI to show the formatted error

Environment

NVIM v0.10.1
Build type: Release
LuaJIT 2.1.1720049189

better-ts-errors version: latest

I don't know what I did, but I see shell stuff

Description

What I see with this plugin:

Error
(TS2339)
Property 'send' does not exist on type 
�]0;nvp@Hephaestus: source "$SCRIPTS/bash-support/command-defaults.sh"��]0;nvp@Hephaestus: source "$SCRIPTS/bash-support/config.sh"��]0;nvp@Hephaestus: source "$SCRIPTS/bash-support/aliases.sh"��]0;nvp@Hephaestus: source "$HOME/shell/bash/npm.sh"��]0;nvp@Hephaestus: source "$HOME/shell/bash/gg.sh"��]0;nvp@Hephaestus: source "$HOME/shell/bash/github-action-runner.sh"��]0;nvp@Hephaestus: source "$HOME/shell/bash/git.sh"��]0;nvp@Hephaestus: source "$SCRIPTS/bash-support/environment-augmentations.sh"�{
  needsControls: boolean;
  splitHorizontally: boolean;
  isMinimized: boolean;
  isMaximized: boolean;
}
.

what my language server reports:

Diagnostics:
1. glint: Property 'send' does not exist on type '{ needsControls: boolean; splitHorizontally: boolean; isMinimized: boolean; isMaximized: boolean; }'. [2339]

Steps to reproduce

no clue, tbh

Expected behavior

some formatted version of what the language server reports

Environment

Neovim version: nighthly
better-ts-errors version: latest

Possible to implement within lsp handler?

Describe the problem

For example, the plugin davidosomething/format-ts-errors.nvim does something similar, but rather than triggering a new buffer/window with a shortcut, they instruct the user to overwrite the existing "textDocument/publishDiagnostics" LSP handler, in order to format the actual LSP error hover. I think having an option to use existing formatting code in this way would be great.

Cache prettified JS objects

Atm prettifying JS objects, if they are bigger than few keys, takes quite some time.
Maybe hashing them and returning output on the consequitive calls would be better
Or use something else for prettifying, like prettierd ?
https://github.com/fsouza/prettierd