oldschoolgg / oldschooljs Goto Github PK

I've started using the library to get some info for a personal project and I noticed that the first 4 boss kcs are incorrect (excluding callisto and cerberus because I noticed the data on them isn't on the response from the API).

Here's my example code

const Hiscores = require('oldschooljs').Hiscores;

Hiscores.fetch('Inversion').then(player => {
    console.log(player.bossRecords);
}).catch(console.error);

this is the response I get:

{ abyssalSire: { rank: -1, score: -1 },
  alchemicalHydra: { rank: 26144, score: 65 },
  barrowsChests: { rank: 28494, score: 81 },
  bryophyta: { rank: 26211, score: 370 },
  cerberus: { rank: -1, score: -1 },
  chambersofXeric: { rank: 1960, score: 1305 },
  chambersofXericChallengeMode: { rank: 1336, score: 40 },
  chaosElemental: { rank: 4324, score: 141 },
  chaosFanatic: { rank: 9087, score: 104 },
  commanderZilyana: { rank: 4668, score: 654 },
  corporealBeast: { rank: 9551, score: 171 },
  crazyArchaeologist: { rank: 72770, score: 3 },
  dagannothPrime: { rank: 22056, score: 316 },
  dagannothRex: { rank: 25908, score: 358 },
  dagannothSupreme: { rank: 21108, score: 338 },
  derangedArchaeologist: { rank: -1, score: -1 },
  generalGraardor: { rank: 14079, score: 477 },
  giantMole: { rank: 91222, score: 2 },
  grotesqueGuardians: { rank: 9831, score: 205 },
  hespori: { rank: 76628, score: 7 },
  kalphiteQueen: { rank: 12531, score: 202 },
  kingBlackDragon: { rank: 20799, score: 340 },
  kraken: { rank: 19926, score: 2015 },
  kreeArra: { rank: 15894, score: 116 },
  krilTsutsaroth: { rank: 17636, score: 100 },
  mimic: { rank: 5164, score: 2 },
  obor: { rank: -1, score: -1 },
  sarachnis: { rank: 14639, score: 21 },
  scorpia: { rank: 1727, score: 484 },
  skotizo: { rank: 34922, score: 23 },
  theGauntlet: { rank: 1103, score: 89 },
  theCorruptedGauntlet: { rank: 2534, score: 4 },
  theatreofBlood: { rank: 970, score: 915 },
  thermonuclearSmokeDevil: { rank: 13580, score: 724 },
  tzKalZuk: { rank: 2054, score: 1 },
  tzTokJad: { rank: 7240, score: 19 },
  venenatis: { rank: 2721, score: 595 },
  vetion: { rank: 5824, score: 74 },
  vorkath: { rank: 12263, score: 877 },
  wintertodt: { rank: 131007, score: 60 },
  zalcano: { rank: 20517, score: 75 },
  zulrah: { rank: 28225, score: 800 } }

The highscores page for this player:
https://secure.runescape.com/m=hiscore_oldschool/a=870/hiscorepersonal?user1=Inversion

You can see there that sire, hydra, barrows and bryophita's scores are wrong.

EDIT:

After going through some other profiles I realized what the problem is, you're not taking into account the highscores for LMS which upsets the first few boss highscores. You should also probably remove Cerberus like you did with Callisto until they make it show up on the api.

https://secure.runescape.com/m=news/chambers-of-xeric-improvements?oldschool=1

Assume no monsters are killed with ROW unless it's coded as optional , with no row as the default

Back in October 2021, Jagex reajusted the revenant's normal table and added secondary drops with blighted items on them.

The bot is still currently using the old normal loot table and should be updated.

The uniques have already been updated here - #326

Ensouled Dragon heads are missing, they was added through a recent poll.
Currently the rate on wiki is unknown, when its known add them to the table.
https://oldschool.runescape.wiki/w/Lava_dragon

How did you calculate the coin weight in gwd bosses drop tables. For example for General Graardor it's 28 here. In the wiki I see it's (31.7 + 1.25)/127? What are the steps to get 28 as the weight for coins?

🐛 Bug Report

The parsing for bosses is now wrong, off by 1. I expect this is relevant to the new RC boss.

I expect Jagex extended the boss CSV list and the delimiters are not reflecting it appropriately.

For example, stats and info for Vorkath are now parsed as Kree'Ara due to the offset issue.

This should also allow the tests to run in parallel = much faster..

Hi,

"await Worlds.fetch()" returns undefined

It doesnt work on runkit either.

Did something break?

Title says it all

🐛 Bug Report

Virtually anywhere an integer is accepted, you can put in a value like:
0m1 or 0k1.

These are interpreted as 100k and 100 respectively.

Example: +pay @user 0m1

Instead of rolling the olm for the user who got a unique, it can give the olm to anyone.

in oldschooljs/src/data/items/
Item ids: 11705,11706 are duplicate name
messes with discord bot, suggest alternatives:

11705: Beach boxing gloves (yellow)
11706: Beach boxing gloves (pink)

🐛 Bug Report

Pretty self explanatory, add grubby key to gourmet. it's 1/500 pre-roll source: https://oldschool.runescape.wiki/w/Gourmet_impling#Pre-roll

appears to be missing from https://github.com/oldschoolgg/oldschooljs/blob/master/src/simulation/openables/Implings.ts

Add Kill Options to monsters. Examples:

• Number of barrows points, whether you have diary completed or not
• Whether youre in task, in wildy, etc
• In catacombs or not

Ring of wealth maybe not as it would probably be a big pain.

🚀 Feature Proposal

It would be very nice if the total GE value of all of the loot is shown as well

🐛 Bug Report

Got zippy from questing but when i do =cl pets it doesn't show on the log.

https://i.imgur.com/LjApdLg.png
https://i.imgur.com/GxcvaaS.png

Also add the new pets wilvus, plopper, etc to CL

🐛 Bug Report

Write a description of the bug here, give all the information you can about what it is, how it happened.

As shown in screenshot, scaly bluedragonhide doesn't appear in the GUI.

Actually, I just tested it on Vorkath as well and doesn't show up there either

🐛 Bug Report

Rogues drop 1 Iron dagger(p) at a rate of 1/128

The current code has Rogues drop 9 Iron dagger(p) at a rate of 1/128

Code link: