okayestdev / osrs-loottable Goto Github PK

Seems like the client thread is being held up while the wiki search is done

Please add the option to disable the right click menu entry. Thanks.

It would be handy to have an option to automatically switch to the loot table tab when using the context menu button. This would be a similar functionality to the player lookup plugin.

Hello,

Love the concept of the loot table plugin! We definitely need more plugins like this! I do have a few observations/suggestions that may or may not be helpful.

-I noticed that there are some inconsistencies with how the drops are displayed. For example, if you search "dagannoth prime" and look at "Ensouled dagannoth head", the value just says "gp", "Nothing" says "N/Agp", and "Silver ore" has some spacing to the right of the value. You might also want to consider, if you haven't already, making it so the name of the item truncates with ellipses if it gets too long so that it doesn't overlap with the quantity. If it does get truncated, or maybe it just does it for everything, but you can have a tooltip that displays the full name of the item when hovering over the drop. I haven't seen an example of this, but with what I've seen with the values, I thought it might be a possibility that it may have been overlooked.

-With how long scrolling can get, I believe that the search should be fixed to the top (not scrollable). Actually, everything above the orange horizontal line should not be scrollable in my opinion. That way, any future options above the orange horizontal line will be fixed to the screen as well. For any future options, those should probably be toggleable to be visible or not in the loottable settings. Maybe the fixing can be an option be toggled on or off in the plugin settings.

-Right-clicking on a monster to display the context menu, you can sometimes see the loot table option be sorted which can get annoying. I haven't looked at any code, but I bet there's a way to do this without having to see that. Depending on the code, it might be to sort before rendering, or previewing the right-click event. Displaying this option in the context menu could also be toggleable in the loottable settings.

-I love that you query the wiki so that it will always be consistent with what the wiki says. I do notice that if I search for a monster that doesn't exist or I spell it wrong, that the search will just hang and I cannot cancel or re-search unless I open a different plugin and come back. The response from the wiki should give you enough information on if the search was successful or not and you can use that response to cancel the search automatically and display some text that says something along the lines of " does not exist". You would also want to do this in case of a timeout for things like if the wiki is down or something - which you would want a different message for. After some more testing, I found that sometimes the failed search does end up returning, but sometimes it takes extremely long (too long to be acceptable) like it has in previous days for me.

-It would also be nice to have search help, but that might be difficult to maintain. I haven't looked, but an elegant solution would be to query the wiki for monsters (hopefully there is a table) and hold that in memory and filter the search help based on what the player types.

-Although this is a loot table plugin, making it a one-stop shop makes it extremely more convenient for the player, and they are more likely to use it more often. I believe the player should also be able to click/right-click on a drop (ground item, inventory/bank item, and in the plugin through search or selecting a drop in a loot table) which can show the drop sources. Clicking on a drop source should open the respective loot table. Now navigation would be nice but can sometimes get difficult, but it would be cool to navigate back to the previous query. For example, I get a sapphire drop in game. I right-click it and select the option to get the plugin to display the drop sources. I then select one of the drop sources to open its loot table. Now I might want to navigate back to the drop sources to select a different one. Maybe an option for the plugin in the settings can be how long you want your history to be with the ability to set it to 0 for no history. When it comes to the query, it looks like the url for the wiki between monster and item is just the difference in the name which is awesome. The response might hopefully tell you what the entity searched for is (monster/item) and you can display the results accordingly. Worst comes to worst, you can add a option that the player can select to tell you if they are searching for an item or a monster. If this is the route taken, that option should have a selectable default by the player in the settings. Another option in settings will be to whether or not display the option in the context menu for items to be consistent with the option to display the option for loot table on monsters.

-It would also be nice to have a button that will open up the wiki for the item/monster that is currently selected which can be visible/invisible based on plugin settings. Granted, there is the wiki button, but that is only useful if I can see the monster next to me. It will not work when I use the search, for example, searching for dagannoth prime while I'm at the bank since I have to be able to do the wiki click on the entity. As I said before, having this plugin being a one-stop shop will make it so much more useful. Granted, opening the wiki will display the page that you got your information from in which case, you might ask what's the point of the plugin then. The player will be able to open the page they want in the wiki in a single click rather than opening the browser. Again, the button can be toggleable so players might not even use it. Also, the plugin is still useful for the same reason that you probably created it for in the first place, which is to display loot without having to open the wiki. My thoughts on having this wiki button in the plugin, is so that I can see the strategies linked to the page in the wiki or locations on where the monsters are found. If you can manage to gather that information and display it in an easy to read, elegant way in the plugin, that could also work rather than adding a wiki button for the currently selected entity.

Note that these are just observations and suggestions, but hopefully you found them useful/inspiring. I look forward to seeing you develop more!

P.S. If you're interested in developing more plugins, I thought it would always be cool to have a collection log plugin that displays your current progress in the plugin pane. I haven't seen any plugin that does this, but there might be a reason why it doesn't exist. I would imagine it is possible since there are plugins that can view your bank without you being there like the "banked xp" plugin. Imagine how cool it can be while grinding out some barrows and seeing that collection log grow with it. It could also be useful for streamers! It might need a refresh button. Anyways, it's just an idea and might not be possible, but figured you might be interested.

Currently it can be very messy to browse the loot table on monsters with a lot of items.

A huge quality of life change would be to split the wiki loot tables into columns in the client. It would look similar to the loot tracker plugin.

Example:

So if you would search up something like Daganoth rex, you would get a column for Talismans, potions, Tertiary etc.
This way you can just open the column you want to watch or have an option to open them all instead of having to scroll through every table.

I'm not sure if anyone has mentioned (I'm new to all of this) but Loot table shows in the plugin section but doesn't actually show up on the runelite tabs to the right anymore. Thank you for looking into this if you already are currently. I appreciate your add ons.

Currently fighting Long-tailed Wyverns, and it seems as though they don't show up in the loot table searcher. Their name pops up, but there is nothing in the tab.

Searching 'Fossil Wyvern' seems to be broken as well.