oizpans / feathers-version-checker Goto Github PK

Steps to reproduce

Following the documentation on how to use the paramsForServer, currentAppVersion will not be added in $client.

Expected behavior

  query: {
    dept: 'a',
    $client: {
        populate: 'po-1',
        serialize: 'po-mgr',
        currentAppVersion: '1.2.3'
    },
  },

Actual behavior

  query: {
    dept: 'a',
    $client: {
        populate: 'po-1',
        serialize: 'po-mgr',
    },
  },

Problem

Adding paramsFromClient on app level hook will ruin all paramsFromClient on service level hook.

Reason

The paramsFromClient will be handled in the app level and will not propagate on the service level hooks. It means that if you have a paramsFromClient handler in app level, all service level paramsFromClient hook will not work.

Reference

paramsForServer
paramsFromClient
example usage

Suggestion

I think we should not use the paramsFromClient on app level hook because it does not conform to the way it was created. This should only be used on service level and be added on service level hook.

Work around

• move all paramsFromClient to app level hook or the other way which is to duplicate the paramsFromClient handler to each service level hook.
• create our own globalParamsForServer && globalParamsForClient
• do a pull request in feathers-hooks-common to change the paramsFromClient behavior on app level hook.

@nateblog @wnxhaja,
if the version-checker cant be used outside feathers-version-checker, how about we merged it here?

lets plot the roadmap before publishing to npm.

can we make the testing on "test" or "tests" directory only?

Example: inside example/server and example/client directories have diff testing. that goes also for package.json.

I would like to re consider designing the logic in inside version checker.

1. check the data is empty.
2. run the validation function,
3. run the check unmatched version function.
4. run updateIsNeeded.