ohanhi / atom-highlight-bad-chars Goto Github PK

If I do a regex search for [\0], then use find-and-replace:find-all to create cursors for each match, the editor deadlocks. This does not happen when your plugin is not active.

Obviously my file contains a lot of hidden nulls.

It would be nice to have a setting to switch to old black-list behaviour.

I switched to vscode with the python extension from jupyter notebooks because for some reason I often had Unicode Character 'ZERO WIDTH SPACE' (U+200B) in my code. This extension does not help me find these errors (see screenshot).

As it does in a normal .txt file (see screenshot):

Maybe chars could be added to the bad list or removed as a setting.

Hello,

the last update leaves all lines in all my files red. It highlights everything as an error. See attached screenshot @ohanhi

Assigning custom properties to a marker when creating/copying it is deprecated. Please, consider storing the custom properties you need in some other object in your package, keyed by the marker's id property.

Function.extractParams - /opt/atom/resources/app.asar/node_modules/text-buffer/lib/marker.js:43:14
MarkerLayer.markRange - /opt/atom/resources/app.asar/node_modules/text-buffer/lib/marker-layer.js:196:71
DisplayMarkerLayer.markBufferRange - /opt/atom/resources/app.asar/node_modules/text-buffer/lib/display-marker-layer.js:90:62
TextEditor.markBufferRange - /opt/atom/resources/app.asar/src/text-editor.js:1753:38
<unknown> - /home/wakematta/.atom/packages/highlight-bad-chars/lib/highlight-bad-chars.coffee:26:29
<unknown> - /opt/atom/resources/app.asar/node_modules/text-buffer/lib/text-buffer.js:950:18```

Specs

• Ubuntu 16.04 LTS
• Atom 13.1

It would be nice to add CEDILLA, which looks similar to a comma (and gets typed on Linux when holding down the compose key and pressing comma twice).

Unicode code point: U+00B8
character: ¸
UTF-8 (in literal): \xc2\xb8
numerical HTML encoding: ¸
name: CEDILLA

Please remove unnecessary line! (highlight-bad-chars.coffee: 72)

In development under disturbing. The console is full of trash.

I like this plugin. I hope to the highlight-bad-chars only works for the selected file type, such as ".c". 'Spell-Check' has the Grammars config option which is a list of scopes for which the package will check for spelling errors. It will be greater if such similar option is added for this package.

There're invalid/incomplete character UTF-8 sequences that editors handle "gracefully" but cause errors when running a script.
Maybe you could also highlight those byte sequences also.

Can we please update the special Microsoft Word unicode characters for apostrophe's and quotation marks?

Example:

• What�s the scope with exchange hosted servers
  

Hi. I really love your plugin. It is very helpful for copy-pasting text to Atom. Also for my Students who are beginners in coding. There’s only a little thing, which is unnecessarily disturbing my eyes: « and » are quotes in Swiss and French and they aren’t bad chars in UTF8 documents.
Cheers, Jürgen

Hi! Thanks for maintaining the highlight-bad-chars package!

In Atom v1.23, we will some changes that may affect your package.

The methods TextEditor.onDidChange and TextBuffer.onDidChange will now call their callbacks less frequently. Previously, these callbacks would get called once for each individual change to the buffer. So if you had 5 cursors and typed a character, they would get called 5 times. Now, they will only get called once, and the event that is passed to them will contain information about all 5 of the changes that have occurred.

The same properties that have always existed on the TextBuffer.onDidChange events (oldRange, newRange, oldText, and newText) will still be there, and they will now reflect the sum of all changes that have occurred. But now there will be an additional property called changes, which will contain an array of more fine-grained objects describing the individual changes. We encourage you to use this property instead of the old ones.

Effects on this package

It looks like this package calls the changed methods in the following places:

• TextEditor.onDidChange
  • here

We found these calls using a regex search, so this list might be incomplete, and it might contain some false positives.

What to do about the change

It is likely that you do not need to do anything. The old event properties will continue to work.

However, you may be able to handle changes more accurately and efficiently by using the changes field of the events rather than the old properties. The changes field does not exist in Atom 1.22 unless you use the TextBuffer.onDidChangeText method. In Atom 1.23 and above though, .onDidChange and .onDidChangeText will become identical, having both the old properties and the new changes property.

Please let me know if you have any questions. I would be happy to help!

I did not find a changelog. Is there one? If not, I would highly appreciate one.

Assigning custom properties to a marker when creating/copying it is
deprecated. Please, consider storing the custom properties you need in
some other object in your package, keyed by the marker's id property.

Function.extractParams (/usr/share/atom-beta/resources/app.asar/node_modules/text-buffer/lib/marker.js:43:14)
MarkerLayer.markRange (/usr/share/atom-beta/resources/app.asar/node_modules/text-buffer/lib/marker-layer.js:196:71)
DisplayMarkerLayer.markBufferRange (/usr/share/atom-beta/resources/app.asar/node_modules/text-buffer/lib/display-marker-layer.js:90:62)
TextEditor.markBufferRange (/usr/share/atom-beta/resources/app.asar/src/text-editor.js:1753:38)
<unknown> (/home/sami/.atom/packages/highlight-bad-chars/lib/highlight-bad-chars.coffee:26:29)
<unknown> (/usr/share/atom-beta/resources/app.asar/node_modules/text-buffer/lib/text-buffer.js:950:18)

Would be nice to have EN and EM DASH characters counted as bad chars.

EN DASH: U+2013
EM DASH: U+2014

http://utf8-chartable.de/unicode-utf8-table.pl?start=8192&number=128

I'd need to highlight the \u2028 too. :)