Got this error after install this theme:

fish: Unknown command 'git_is_repo'
~/.config/fish/functions/fish_prompt.fish (line 29):
  if git_is_repo
     ^
in function 'fish_prompt'
	called on standard input

in command substitution
	called on standard input

This is my rodeo with fish so please let me know if this issue needs to be raised somewhere else

when i install theme-default in windows WSL with omf, some characters show messy code:

Hi Team,

First, sorry for creating an issue. I couldn't able to find any links says how to publish or install locally oh-my-fish theme.
I have created a theme out of theme-default to theme-default-git. Can you please suggest the steps I need to follow.
theme-default-git

When using the same default theme in several machines, the users may get slightly confused about which machine they're logged in, with which user, etc.

The default theme could provide a simple way so the user can easily figure that out.

This is a nice feature that the pure prompt has. It would be easy to adapt their implementation (here) into this prompt.

How it looks in pure, excuse the color scheme. Just installed it for this example screenshot

Not sure what the contribution process is for this repo, but happy to open a PR if this would be accepted!

I installed this theme with fisherman using fisher omf/theme-default.

Everything works great except the normal prompt has a blue background as in the screenshot.

Does anyone encounter the same problem?

Description
While connected to a system with fish installed through SSH, the default theme calls 'hostname' without ever checking if it exists, or listing it as required.

At the beginning of each new line the terminal spits out an error, trying to fill-in the hostname of the ssh host.

fish: Unknown command: hostname
~/.local/share/omf/themes/default/functions/fish_prompt.fish (line 1): 
hostname -s
^~~~~~~^
in command substitution
	called on line 34 of file ~/.local/share/omf/themes/default/functions/fish_prompt.fish
in function 'fish_prompt'
in command substitution
 ~

Workaround
Install a hostname function
or
create hostname as a function to echo $hostname
or
set $theme_ignore_ssh_awareness = yes

Environment report

Oh My Fish version: 7
OS type: Linux
Fish version: fish, version 3.7.1
Git version: git version 2.45.2
Git core.autocrlf: no
Checking for a sane environment...
Your shell is ready to swim.

This theme offers a fish_right_prompt by default, and while we all agree that changing defaults is a bad thing, not having a way to easily configure that is also not optimal.

The current way to ignore the right prompt is creating an empty fish_right_prompt function in ~/.config/fish/functions/fish_mode_prompt.fish, which is far more complicated than setting up a configuration variable for this.

As at the end of day having or not the right prompt displayed is something that's up to the user's personal taste, let's expose an option so users can opt-out from that, if that's their wish.

https://user-images.githubusercontent.com/6078758/32414540-62e5ab88-c264-11e7-8a0f-8e1f4599906a.png

macos 10.13.1 termial and iterm both have this problem

The fish prompt is displayed incorrectly using the GNOME terminal on Ubuntu 14.04. I also tried the Powerline fonts, but the same issue.

Currently, in case the user has decided to switch all the terminal instances they have access to to using fish with oh-my-fish, and they go for this very same theme in all instances (why not, right? this theme rocks! ;-)), they'll soon enough realise there's absolutely no indicator on whether you're running as root or not.

We should provide some differentiation, something that catches the user's attention, when they're running as root.

I'm opening the issue and not yet providing a PR as I think how we provide this is something that should be discussed first, as the default theme is quite lean and we don't necessarily want to make it too much.

@bpinto @scorphus, ideas on how to approach this one?

I was wondering what the color scheme and font was used for the theme screenshot in README.md:

I can't find a font that correctly renders the fish glyphs, so it would be a useful addition for people using this theme to see what font the screenshot was taken with.