Git Product home page Git Product logo

Comments (3)

rgaudin avatar rgaudin commented on July 17, 2024

In theory, yes but Order deletion is not a common feature. It's an admin-only feature that should be used solely to clean up erroneous Orders. It should be used only exceptionally.

It doesn't trigger anything, it just deletes data.

Cancelling a task is fundamentally opposed to Order removal as canceling is asynchronous: an Order canceled requests task cancellation which happens in the future. Only after tasks and order are completely canceled (and user informed) can the data be deleted.

Implementing this properly for a feature that should normally not be used is probably not worth the effort… at this stage.

from cardshop.

Popolechien avatar Popolechien commented on July 17, 2024

Fair enough. I've done the mistake once so should know better for next time, but I'd like to leave this ticket open as it is important to have safeguards.

from cardshop.

rgaudin avatar rgaudin commented on July 17, 2024

Won't fix. we should not delete in-progress orders

from cardshop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.