offspot / cardshop Goto Github PK

I had about 20 small files on my list and then clicked "update" and got this error log:
´´´

Error during template rendering
In template /app/manager/templates/base.html, error at line 0

Environment:

Request Method: GET
Request URL: https://cardshop.hotspot.kiwix.org/configurations/2

Django Version: 2.1.2
Python Version: 3.6.6
Installed Applications:
['django.contrib.admin',
'django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.sessions',
'django.contrib.messages',
'django.contrib.staticfiles',
'manager']
Installed Middleware:
['django.middleware.security.SecurityMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'django.middleware.common.CommonMiddleware',
'django.middleware.csrf.CsrfViewMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'django.contrib.messages.middleware.MessageMiddleware',
'django.middleware.clickjacking.XFrameOptionsMiddleware']

Template error:
In template /app/manager/templates/base.html, error at line 0
tw
1 : {% load static %}
2 :
3 :
4 : <title>{% block title %}Kiwix Hotspot Cardshop{% endblock %}</title>
5 :
6 :
7 :
8 :
9 :
10 : <style type="text/css">

Traceback:

File "/usr/local/lib/python3.6/site-packages/django/core/handlers/exception.py" in inner
34. response = get_response(request)

File "/usr/local/lib/python3.6/site-packages/django/core/handlers/base.py" in _get_response
126. response = self.process_exception_by_middleware(e, request)

File "/usr/local/lib/python3.6/site-packages/django/core/handlers/base.py" in _get_response
124. response = wrapped_callback(request, *callback_args, **callback_kwargs)

File "/usr/local/lib/python3.6/site-packages/django/contrib/auth/decorators.py" in _wrapped_view
21. return view_func(request, *args, **kwargs)

File "./manager/views/config.py" in edit_configuration
145. return render(request, "edit_configuration.html", context)

File "/usr/local/lib/python3.6/site-packages/django/shortcuts.py" in render
36. content = loader.render_to_string(template_name, context, request, using=using)

File "/usr/local/lib/python3.6/site-packages/django/template/loader.py" in render_to_string
62. return template.render(context, request)

File "/usr/local/lib/python3.6/site-packages/django/template/backends/django.py" in render
61. return self.template.render(context)

File "/usr/local/lib/python3.6/site-packages/django/template/base.py" in render
171. return self._render(context)

File "/usr/local/lib/python3.6/site-packages/django/template/base.py" in _render
163. return self.nodelist.render(context)

File "/usr/local/lib/python3.6/site-packages/django/template/base.py" in render
937. bit = node.render_annotated(context)

File "/usr/local/lib/python3.6/site-packages/django/template/base.py" in render_annotated
904. return self.render(context)

File "/usr/local/lib/python3.6/site-packages/django/template/loader_tags.py" in render
150. return compiled_parent._render(context)

File "/usr/local/lib/python3.6/site-packages/django/template/base.py" in _render
163. return self.nodelist.render(context)

File "/usr/local/lib/python3.6/site-packages/django/template/base.py" in render
937. bit = node.render_annotated(context)

File "/usr/local/lib/python3.6/site-packages/django/template/base.py" in render_annotated
904. return self.render(context)

File "/usr/local/lib/python3.6/site-packages/django/template/loader_tags.py" in render
62. result = block.nodelist.render(context)

File "/usr/local/lib/python3.6/site-packages/django/template/base.py" in render
937. bit = node.render_annotated(context)

File "/usr/local/lib/python3.6/site-packages/django/template/base.py" in render_annotated
904. return self.render(context)

File "/usr/local/lib/python3.6/site-packages/django/template/defaulttags.py" in render
161. values = self.sequence.resolve(context, ignore_failures=True)

File "/usr/local/lib/python3.6/site-packages/django/template/base.py" in resolve
698. new_obj = func(obj, *arg_vals)

File "./manager/templatetags/manager.py" in as_packages
56. for pid in json.loads(value) or []

File "./manager/templatetags/manager.py" in
56. for pid in json.loads(value) or []

Exception Type: KeyError at /configurations/2
Exception Value: 'tw'

GET
No GET data

POST
No POST data

FILES
No FILES data

META

SETTINGS

Like any other node, it should be available only via SSL.

It should by definition indicate the card's size - right now it let's me chose an 8Gb card for an 128Gb config. I don't see why/how the user should chose differently.

Currently the interface rightly says it's not an option, but doesn't prevent users from doing it

It is current "GiB". See https://en.wikipedia.org/wiki/Gigabyte

Currently when trying to place an order and no address has been registered, this is not really indicated as a missing information in the Recipient field. Maybe circle it in red and/or add text "no delivery address available".

Related to #3 - I don't know if should be merged with this ticket or not, but basically I wasn't able to retrieve the page where my credits are listed (unless I logged out and then back in). So the top of the Config page, being where most people will want to start their journey, should have the current landing's wording.

Hi {{username}}!
Welcome to the Cardshop. Here you can freely import, design and export Kiwix Hotspot's presets (JSON files).

etc. etc.

Part of the text reads:
"Both option require you to pay a fee ^{using a prepaid units system} but obviously the virtual one is cheaper.

We don't need the superscript, or even the text in it - if people have access, they've paid the fee already and know what they got themselves into.

Currently 12 characters - push it maybe to 24 ("Orange South Africa" has 19)?

It looks like it is mostly wiki-related, but what is the need for it, really?

When pressing the update button on content or branding the user is sent back to the General tab. He/she should rather be directed to the logical next step
General > branding > content > adress > order

Added a local phone number without the country code and got a rather cryptic error message:

I suggest pre-filling the text field

• country code + number or
• +1 123 456 789 or
• Simply replace the "Country" field with a "Country name/ code" dropdown (and invert country/email address fields so that it is right next to the phone number field)

Following discussion with @Popolechien, we might want the shop to offer image-creation service instead of physical SD-card.

Difference with the current workflow would be:

• No address
• Order complete once image is uploaded by creator worker
• Expiration of download link (a week ?)

Challenges:

• Support this use case (work)
• Blocks disk space for the duration of the download period on the warehouse
• How would we charge for this ?

The landing page lists past orders (I suppose), and if there aren't any the most prominent item is the password change box. This is rather confusing.

And add a sorting option on top of each column so that people can either sort if by one or the other. I got confused thinking there was only one Wikipedia available in French and then only saw it much further down (same for WikiSource).

The distinction is purely technical and has no bearing on end product.

In case users don't have a favicon and logo at hand, at least the space does not remain empty.
Also, the wording should be clear about it:
"This section allows you to replace some visual elements with your own branding. Currently the Kiwix logo will be used by default".

Kiwix logo can be found at: https://upload.wikimedia.org/wikipedia/commons/1/14/Kiwix_icon.svg

(based on user feedback)

Currently upon ordering a card a single email is sent to

1. The person who placed the order online (the Client)
2. The person who is meant to receive it (the Recipient]

These may or may not be the same individual.

Here are the current text and fields being used:

Dear [Recipient],
Your order of 1 x 64GB Download with the [configuration's name] configuration on it has been accepted by the system.
You will be notified when it is ready for download.

Should you have any question, your contact for this transaction is [Client] (copied).
Order ID [some number with link to order details on cardshop]
Size: Card size (as opposite to content size)
Quantity: _number of units ordered, or 1 if download
Units: nn.d
Destination: (e.g. Recipient's address)
Cardshop contact Client's email address
Status: created, date/hour

To avoid confusion, this should be split in two messages:
Client message: (putting changes in Bold
"Success!
Your order of 1 x 64GB Download with the [configuration's name] configuration has been accepted by the system.
[Recipient] will be notified, and will get another message when it is ready for download.

Order summary:
Order ID [some number with link to order details on cardshop]
Size: Card size
Quantity: number of units ordered, or 1 if download
Unit cost: nn U (<- note: removed the decimal count in the number of units)
Destination: (e.g. Recipient's address)

You have XYZ units left on your account."

Recipient message
"Good news!
Client has placed an order for you on the Kiwix Cardshop. You will receive another message when the content is ready for shipping or download."

So that people understand they have to navigate from one tab to the other (see below pic taken from Donorbox dashboard).

Emails are essential to the scheduler as it is though emails that it communicates with its users: recipients, clients (person who orders on the website) and writer operators.

scheduler uses SMTP to connect to a mailbox [email protected] to send emails.

While this works locally, it doesn't work on Sloppy dues to Spam mitigation strategies (at Gandi but also at Gmail and probably any Email provider).

• External IP is unpredictable (although it is safe to assume it's from their German provider)
• Our external IP has-been/is/could-be listed in a RBL list of spamming IPs. We have no control over it and should it happen, our emails are rejected.
• Our external IP does not follow anti-spam guidelines regarding reverse records resulting in rejects.

To circumvent this, I have added support for mailgun HTTP API as an alternative (used if MAILGUN_API_KEY env is specified) to SMTP.

Mailgun offers 10,000 emails/month with their free package (see pricing) and has a simple API. It's a dedicated service which handles emails correctly. Instructions to verify domains are easy and they have incoming email support (webhooks).

Amazon offers a similar service AWS SES but it seems the free 65K emails/months are only for apps hosted on AWS.

Way forward:

• Create a Kiwix account on Mailgun
• Follow DNS instructions for cardshop.hotspot.kiwix.org domain.
• Share credentials/API key.

See #43 - but not a priority at this stage as this is probably going to be an edge case.

Use case: I generated a list, then removed some items. When the mouse hovers on the +/- symbol then the file name appears. In this case I removed bangla content and added english, but the mousehover text box did not clear properly (even when clicking randomly around the window).

As a quickfix, I would probably no show these text boxes in the first place.

Added StackOverflow to my shopping cart but eventhough the size was added to the card, the item itself wasn't.

The duplication is confusing and takes up unneeded space

Right now if I saved and made a mistake in my addressing I need to delete and re-create the entry. Simply add an edit button next to the delete one in the list of addresses.

The "Link validity" is not needed (it sounds rather greedy to triple the cost when tripling duration). Let's set a default to seven days (or 10, whatever), have it notified in the delivery email, and be done with it.

The Quantity dropdown could be replaced by a text field : it's easier to type 5 than dropdown>scroll down > select.

In the case below I have 8.39 Gb of content on an 8Gb card. Might be a problem with rounding?

Pressing the "delete" button next to an address does not work.

Contact should be hotspot at kiwix.org - I don't think a personal address makes much sense (roles and responsabilities evolve, people go on vacations) and it's easier to track and manage tickets like this on Freshdesk.

Here for instance I had selected Khan Academy (10Gb), the file size has been correctly updated but it does not show in my package/config list.

I have a 126 Gb config that requires a 200Gb card and a 63.97 Gb card (in the content manager) that shows 64.61 Gb (in the config manager) that needs a 128 Gb card.

The current structure is 1Gb = 1 Unit. Hardware prices, however, are not linear: a quick benchmark on Amazon gave the following prices: 8 / 10 / 15 / 30 / 50 / 70 USD for 16/ 32/ 64/ 128/ 200 and 256 Gb, respectively, ie an 9x ratio between the smallest and biggest ones.

Prices will evolve but hopefully the ratio will remain within those boundaries. I would therefore attribute 2 Units to 16Gb cards (and below; if someone for some reason orders an empty-ish card, we still need to cover handling), then 3, 4, 8, 13 and 18 units.

Since this is the last step, Save is an option, but not the most likely one: users will probably want to close the deal and finalize their order. There should therefore be at least a "Next" button but most likely something more of a call to action, like "Order card!/"Place order"/"Confirm delivery address"

Also the Save/Next button(s) should be located under the Selected package list: if I'm looking at Afar then it's fine and not too far, but in English I'd have to scroll quite a bit before finding it.

Someone who only wants a download link has no reason to send this info.

Probably related to #12 : when adding which ever stackexchange package to my selected contents, it does not move from the "available" to "selected" list, yet its weight is added to that of the card.

Looks like the library is not showing the last generated Stackexchange Zim files for a given topic, but all zims

Already mentioned in #37: basically the update button could work as "Next" and take the client from
General to Branding to Content to Address to Order (meaning that order and address should not only be as top right menu items but also as part of the Configuration tabs.
Alternatively, if for some reason this is too complex to implement, add a "Order!" button below "update configuration" on the Content tab.

When writing their address users have had to type pretty much everything already, so they can type their home country as well - also some browser will fill that field automatically from previous forms, it'll always be faster than looking for a specific country in a 200+ list.

For security reasons. HTTP should be forwared to HTTPS.

If addresses or preexisting orders have been made, then the current display is fine.

Currently not sure it's the image I want.
Also, is there a suggested size (e.g. square), or minimum (50*50px)?

Question: do we really need a favicon? People might get confused as to what this is, and honestly it's not that important on a tab (case in point: the cardshop does not have a favicon). I'm not asking to remove it, but I wouldn't see a drawback to branding all tabs with a default Kiwix favicon.

How many use cases do we plan of people adding their own CSS? If the answer is "not many", I'd probably remove that option for the time being or, better, only have it appear on Admin accounts along with the favicon option (my understanding is that there will be admin accounts like mine and user accounts for FO end-users)

Currently everyone can see everyone else's card creations, this is confusing and will quickly create clutter.

I have three configs but the dropdown only shows two.

Currently having no content whatsoever is already 7.27 Gb.

Tried to resend a previously generated order/config to a different address and got a "Error while saving - Response Error (no JSON)" when pushing "order now"

• Project name
  -> Rename to "Hospot name" (otherwise we have two boxes next to one another with the word "name" in it, irrespective of explanations in field box. It also connects logically with the suggested "Kiwix hotspot" name);
  -> "Used to name your Box and its WiFi network" (missing network word);
• Name (as in Configuration name): add star * and make sure this one is mandatory;
• Region: there is a bit of French ("language en") and it should be clearer where that language will be applied, (e.g. "Hotspot interface language")
• Timezone: add UTC/GMT values if possible
• Security: are the admin/admin password fields mandatory if we install Aflatoun & co?
  

The version column indicates the date at which the zim file was generated: I see no added value to this info as:

• People should not have a choice between the most recent and an older version of the zim file;
• Since we do not update (yet) our zim file on a daily basis this lower the signaled value of our content by making it look stale.

I was looking at Bangla content, then wanted to change language but instead of going to Arabic or English selected back the default "Select to filter". Was returned an error message

I'm using Apple's desktop nightmore for my mail client and the download link appears black on black (I suspect that if the font color wasn't set it would work out fine?)

Right now we can export but not simply delete. Also use "download" rather than "export".