Handle retired ZIM about cardshop HOT 5 CLOSED

from cardshop.

OK, there are two known issues here:

• catalog synchronization. The cardshop caches the catalog for 24h. I believe in this case, the catalog has changed recently and we shall see a single occurence of Science In The Bath tomorrow. This will be partly fixed by the move to OPDS (#131) although we'd still use some cache. I suggest to shrink the current cache to 3h now.
• ZIM obsolescence. As far as the Cardshop is concerned, those are just two different ZIMs because they have different names so it's not a duplicate. The problem is (error is at hotspot which downloads the catalog on launch) that the referenced ZIM is not in the catalog anymore (meaning that its file is not downloadable anymore). We've already discussed this but I couldn't find the issue (or we didn't create one?). We need to define a practical way to handle such case:
  • silently remove the unavailable ZIM from the order and pursue (might be the only ZIM or content though!)
  • fail the order with an error message indicating a selected ZIM has retire and configuration must be updated.
  • something else?
    In addition, we need a system that checks for retired ZIM in configs and informs users about the issue. When? On config edit ? on Order placement ?

from cardshop.

@rgaudin Independently of any other consideration, the cardshop recipe should be checked as early as possible against the library opds stream... to avoid later crash.

Related to openzim/cms#7

from cardshop.

Doesn't answer the question of the when except for the obvious “on order creation”. Just to be clear, the current check is at installer startup so first thing once the task is picked up by the worker. We'd want the cardshop to check that before scheduling the order… using OPDS, once we add OPDS support.

from cardshop.

@rgaudin Yes, Cardshop should be able to test a recipe periodicaly and even before a creator is started.

from cardshop.