officinearduinotorino / node-red-contrib-schneider-powertag Goto Github PK

Hi Albydnc,
I have tried my first pull request (I've added two modules in the read me under equipment testing). When i try and do a pull request it says I'm forbidden. Do I need to be added to your project as a contributor?

The extractor uses a variable that is not defined. The code needs changing to convert the number to human readable. The variable realValue will probably disappear.

This applies to the run hour counter measurements which are not yet configured in the powerTag node.

Fix this when adding the run hour counter capability to the powerTag node.

@hotswapster I am going to move the repository to https://github.com/OfficineArduinoTorino/node-red-contrib-schneider-powertag

@hotswapster I've seen your extractor.js code, thanks for contributing! As I read, I've seen you are using msg.ptTopic to pass info to the extractor, meanwhile I was using the msg.topic in the powertag.js, I think we should decide what convention to utilize. My choice was based on the fact that NodeRED has topic as a core object of the message. Let me know your opinion!