Discussed in #26

When trying to download the latest version Windows Defender said it was a Trojana

The Bug
If you run the Downloader with tags longer than 256 char it breaks as the output folder name cant be longer then that.

Error
[WinError 123] The filename, directory name, or volume label syntax is incorrect: 'media/22-06-2024_12-52-58_-vore_-death_-flash_-fart_-nipple_vore_-breast_expansion_-vore_pov_-unbirthing_-pooping_-body_size_growth_-urine_-soiling_-muscular_-big_breasts_-big_penis_-thick_thighs_de4dm1lk_fleurfurr_lettuce_artist_kind_lurker_ssevisx_81yffulfmm_noxxlss_ruffruffles_lintwave_4hazelstreet_uricomics_dudles_codyblue-731_100racs_replicant_skrunkle_lemonbird_rilesthecat_entom_kyufuru_lyonley_slashkill_domibun_lilmoonie'

To Reproduce

1. Run the Downloader
2. Select e621
3. Type in any tags as long as they are, in total, longer than 256 characters
4. See error

Expected behavior
Downloader should run normally (maybe allow users to name output folders / change them, as planned in #31)

Screenshot

Desktop:

• OS: Windows
• Version 11

Used Parameters and Settings:

• Site: e621
• Tool Version: v.1.6.3
• Tags/Link (EXAMPLE): -vore -death -flash -fart -nipple_vore -breast_expansion -vore_pov -unbirthing -pooping -body_size_growth -urine -soiling -muscular -big_breasts -big_penis -thick_thighs ~de4dm1lk ~fleurfurr ~lettuce_(artist) ~kind_lurker ~ssevisx ~81yffulfmm ~noxxlss ~ruffruffles ~lintwave ~4hazelstreet ~uricomics ~dudles ~codyblue-731 ~100racs ~replicant_skrunkle ~lemonbird ~rilesthecat ~entom ~kyufuru ~lyonley ~slashkill ~domibun ~lilmoonie

runtime.log
runtime.log

Discussed in #33

Would it be possible to add an option to download the tags associated with an image, possibly to a /metadata/[date][time][tags]/ directory?

Errno 13 when trying to download fav:masuteri tag

To Reproduce

1. run the app for the first time
2. Set the blacklists to [], put in api key and name and save
3. Run it again, choose e621 and as the tag fav:masuteri with pagecount left empty
4. Observe

Expected behavior
All media should get downloaded

Screenshots

Desktop

• OS: Windows
• Version 11

Used Parameters and Settings (please complete the following information):

• Site: e621
• Tool Version: 1.4.3
• Tags/Link: fav:masuteri

runtime.log

Describe the bug
Setting oneTimeDownload to false in the config will crash the program.

As reported by user @r2ten-catuncle in #18

Developer Privileges, i don't need to fill out the rest.

Is your feature request related to a problem? Please describe.
I see in the config.json that there is an option for oneTimeDownload, defaulted to true. There is no documentation around this, but I'd assume that if you turn oneTimeDownload to false then your downloads should become differential. In other words, if you download a tag that has 20 posts today, and tomorrow it has 25 (of which you already have 20), then re-running that download should only download the 5 posts that are missing.

Looking through the code, this does not seem to be implemented in any of the downloaders, and is only read from the config file in main.py.

Describe the solution you'd like
The oneTimeDownload feature should be implemented as described above.

Describe alternatives you've considered
It is easy enough to simply merge previously downloaded folders together for specific tag sets, however this causes multiple downloads of the same post, and therefore unnecessary requests to the site's API.

Additional context
This was tested on e621, but should also be non-functional on all other sites as the feature is simply not implemented.

Site URL
N/A

Does the site have an API?
N/A

To Reproduce
Steps to reproduce the behavior:
Launch and configure the latest release of NNDownloader (1.4.2 at time of writing)

Expected behavior
A clear and concise description of what you expected to happen.
I type in a tag like "animated" and I get
Downloading |⚠︎ | (!) 0/320 [0%] in 0.8s (0.00/s)
[!] An error occured while downloading from e621! Please report this. Exception: cannot access local variable 'safe_user_tags' where it is not associated with a value

Any tag I type it doesn't work.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Windows
• Version 11

Used Parameters and Settings (please complete the following information):

• Site: e621
• Tool Version: NN
• Tags/Link: animated

Please attach the runtime.log

runtime.log

Describe the bug
When using the auto updater, the update applies correctly. However, the auto updater still shows the application as outdated.

To Reproduce

• Launch and configure the latest release of NNDownloader (1.4.0 at time of writing)
• The auto updater will prompt you to download the "latest version"
• Update to this version and relaunch NNDownloader
• The auto updater still prompts to update

Expected behavior
The auto updater should not prompt you to update when you are on the latest version

Screenshots

Used Parameters and Settings (please complete the following information):
N/A

Additional context
I believe this issue is caused by a mismatch between the versioning provided by the GitHub API and checking against the version in the config file. I did try to modify the config version to 1.4.0, however this is not valid JSON as the version is currently stored as float.

This is from a quick glance through the code though and could be completely wrong - I'm not familiar with python.

Describe the bug
I tried running the tag "tail" for E621 and got the error:
"[!] An error occured while downloading from e621! Please report this. Exception: cannot access local variable 'meta_tags' where it is not associated with a value"
Persists even when running the .exe as administrator

Tbh Idk how you'd reproduce it, I downloaded the .exe and after I ran it, set up the API etc. just couldn't download

Screenshots

Desktop:

• OS: Windows
• Version 11

Tool:

• Site: e621
• Tool Version: 1.6.0
• Tags/Link: tail

I have to say that I am in no way a coder nor know anything about this. I already struggled with the API settings 😅

Runtime Log
runtime.log

Thanks in advance

More specifically, for some reason, it refuses to download anything by ConnivingRat off e621. I am on Win10.

Steps to reproduce the behavior:

1. Select E621
2. Type "connivingrat" and try to download any number of pages.
3. ???

Screenshot:

For some reason there is no log file with the program either so I can't find out the error either...

Describe the solution you'd like
I would love to see this site added as i think the API is similar if not the same to e621

Site URL
https://e6ai.net/

Does the site have an API?
Yes, https://e6ai.net/help/api

Discussed in #28

After downloading a tag, after moving the folder out, I cannot download the same tag again.
I don't know if there is something wrong with my operation

Describe the bug
Program crashes due to missing tags for Furbooru and Rule34.

Developer Privileges, i don't need to fill out the rest.

heyy im kinda new at github and i dont actually know how to download it correctly (or at least how to execute it)

at first ive tried to click on "windows donwload"
but it ends creating and downloader wich just keeps creating 2 empty folders and one text (config)
and ive even tried to download it with linux but i wasnt able to to found an applicantion to actually start the nn-donwloader, since ive tried to open almost everysingle archive in that folder...

im pretty sure that im just being really stupid on trying to find how to use it but plz, help me TwT

btw excuse my bad english, im still learning it