odalet / delta.units Goto Github PK

Hello, there!

As part of the university research we are currently doing regarding the security of Github Actions, we noticed that one or many of the workflows that are part of this repository are referencing vulnerable versions of the third-party actions. As part of a disclosure process, we decided to open issues to notify GitHub Community.

Please note that there are could be some false positives in our methodology, thus not all of the open issues could be valid. If that is the case, please let us know, so that we can improve on our approach. You can contact me directly using an email: ikoishy [at] ncsu.edu

Thanks in advance

1. The workflow build.yml is referencing action gittools/actions/gitversion/setup using references v0.9.5. However this reference is missing the commit 90150b4 which may contain fix to the vulnerability.
2. The workflow build.yml is referencing action gittools/actions/gitversion/execute using references v0.9.5. However this reference is missing the commit 90150b4 which may contain fix to the vulnerability.

The vulnerability fix that is missing by actions' versions could be related to:
(1) CVE fix
(2) upgrade of vulnerable dependency
(3) fix to secret leak and others.
Please consider updating the reference to the action.

If you end up updating the reference, please let us know. We need the stats for the paper :-)

Globalization unit tests may fail, probably because of parallelization of tests (eg here: https://github.com/odalet/Delta.Units/runs/1405569681?check_suite_focus=true)

The only way to define the 'Translation Provider' is to use the global static property DefaultUnitTranslationProvider.Current. Unit Tests in https://github.com/odalet/Delta.Units/blob/master/src/UnitTests/UnitTests.Delta.Units.Globalization/CustomTranslationsTests.cs set it and revert it in a finally block, but this is not safe.

See

• https://en.wikipedia.org/wiki/Imperial_units
• https://en.wikipedia.org/wiki/United_States_customary_units
  for reference

Beware of potential differences between US and UK/Commonwealth

• VS 2019
• GitHub Actions
• Remove AssemblyInfo.cs -> Directory.Build.props
• GitVersion
• Sonarcloud
• SourceLink + snupkg (See #4)
• Get rid of develop branch