ocha-dap / hdx-python-utilities Goto Github PK

Tests for https://github.com/OCHA-DAP/hdx-analysis-scripts which pass in GitHub Actions fail on Windows because the compare_files function does not specify an encoding at this line for the open calls:

When no encoding is provided Python uses the system default encoding which is different for Ubuntu and Windows. This can be resolved by explicitly specifying an encoding for the open calls of utf-8. An optional encoding argument could be provided to the compare_files function which would handle rare cases when non-UTF-8 files were to be compared. This makes the reasonable assumption that both files to be compared would have the same encoding.

This package is a dependency for hdx-python-country, see OCHA-DAP/hdx-python-country#14

/cc @turnerm

Dependencies:

• basicauth (conda package: pr conda-forge/staged-recipes#21610)
  • blocked: rdegges/python-basicauth#9)
• beautifulsoup4==4.11.2
• email_validator==1.3.1
• frictionless[excel,json]>=4.40.8 (blocked: conda-forge/frictionless-feedstock#93)
• frictionless==5.5.1
• ijson>=3.0
• jsonlines>=1.2
• loguru
• openpyxl>=3.0
• python-dateutil==2.8.2
• ratelimit
• requests-file
• ruamel.yaml
• tableschema-to-template>=0.0.12 (conda package: conda-forge/staged-recipes#21936)
  • blocked by hubmapconsortium/tableschema-to-template#28
  • jsonschema>=1.0.0
  • pyyaml>=3.13
  • xlsxwriter>=1.2.8
• xlrd>=1.2
• xlwt>=1.2

The requirement typing==3.6.6 is needed only for Python versions less than 3.5. Typing was moved to standard Python lib in 3.5 and on certain deployments such as AWS and Azure it creates issues.

See also: https://fernandomc.com/posts/issues-with-typing-python-3/

I propose the modification of requirements.txt by changing

typing==3.6.6

to:

typing==3.6.6; python_version < '3.5'