oceanwp / ocean-extra Goto Github PK

The OceanWP admin button's notifications appears to be missing it's styles that creates the notification bubble in the admin bar. I created a custom fix for myself but it may still persist for others.

I was working on a project using OceanWP which comes with the ocean-extra plugin. I installed Custom Sidebars plugin by WPMU Dev to add more functionality and flexibility to the sidebars.

After activating the plugin, and making some changes in the sidebar widget options. It just keeps loading as you can see in the image below.

When checking the dev console, there's an Uncaught TypeError: settings.data.search is not a function. See following image:

Clicking on the widgets.php file will show the file and the line where the error is coming. And yes, it comes from the about-me.php and social.php in ocean-extra/includes/widgets directory.

I did a temporary fix by updating some lines from:

if ( settings.data.search( 'action=save-widget' ) != -1 && settings.data.search( 'id_base=' + widget_id_base) != -1 ) { oceanwpSortServices(); }

to the following:

if (typeof(settings.data) !== 'undefined' && typeof(settings.data.search) !== 'undefined') { if ( settings.data.search( 'action=save-widget' ) !== 'undefined' && typeof(settings.data.search( 'id_base=' + widget_id_base)) !== 'undefined' ) { oceanwpSortServices(); } }

That fixed the issue though. But I have to do that over and over again every time there's an update from ocean wp theme core files/plugins.

Fatal error: Uncaught Error: Undefined constant "OCEANWP_CSS_DIR_URI" in /home/locean/public_html/wp-content/plugins/ocean-extra/includes/menu-icons/includes/library/icon-selector/includes/types/font.php:68 Stack trace: #0 /home/locean/public_html/wp-content/plugins/ocean-extra/includes/menu-icons/includes/library/icon-selector/includes/types/base.php(62): OE_Icon_Picker_Type_Font->get_stylesheet_uri() #1 /home/locean/public_html/wp-content/plugins/ocean-extra/includes/menu-icons/includes/library/icon-selector/includes/types/font.php(91): OE_Icon_Picker_Type->_get('stylesheet_uri') #2 /home/locean/public_html/wp-includes/class-wp-hook.php(308): OE_Icon_Picker_Type_Font->register_assets(Object(OE_Icon_Picker_Loader)) #3 /home/locean/public_html/wp-includes/class-wp-hook.php(332): WP_Hook->apply_filters(NULL, Array) #4 /home/locean/public_html/wp-includes/plugin.php(517): WP_Hook->do_action(Array) #5 /home/locean/public_html/wp-content/plugins/ocean-extra/includes/menu-icons/includes/library/icon-selector/includes/loader.php(78): do_action('oe_icon_picker...', Object(OE_Icon_Picker_Loader)) #6 /home/locean/public_html/wp-content/plugins/ocean-extra/includes/menu-icons/includes/library/icon-selector/includes/loader.php(59): OE_Icon_Picker_Loader->__construct() #7 /home/locean/public_html/wp-content/plugins/ocean-extra/includes/menu-icons/includes/library/icon-selector/icon-selector.php(194): OE_Icon_Picker_Loader::instance() #8 /home/locean/public_html/wp-content/plugins/ocean-extra/includes/menu-icons/includes/library/icon-selector/icon-selector.php(127): OE_Icon_Selector->init_loader() #9 /home/locean/public_html/wp-includes/class-wp-hook.php(308): OE_Icon_Selector->init('') #10 /home/locean/public_html/wp-includes/class-wp-hook.php(332): WP_Hook->apply_filters(NULL, Array) #11 /home/locean/public_html/wp-includes/plugin.php(517): WP_Hook->do_action(Array) #12 /home/locean/public_html/wp-settings.php(645): do_action('wp_loaded') #13 /home/locean/public_html/wp-config.php(91): require_once('/home/locean/pu...') #14 /home/locean/public_html/wp-load.php(50): require_once('/home/locean/pu...') #15 /home/locean/public_html/wp-admin/admin.php(34): require_once('/home/locean/pu...') #16 /home/locean/public_html/wp-admin/plugins.php(10): require_once('/home/locean/pu...') #17 {main} thrown in /home/locean/public_html/wp-content/plugins/ocean-extra/includes/menu-icons/includes/library/icon-selector/includes/types/font.php on line 68

Please help me to fix the issue as the testing shown that only ocean extra plugin activated and gave an error.

Hi!
The new commit 19ca735 seems to break Wordpress for me.

PHP Fatal error:  Cannot redeclare oceanwp_webfonts_enqueue() (previously declared in [...]/wp-content/plugins/ocean-extra/includes/compatibility/ocean.php:94) in [...]/wp-content/themes/oceanwp/inc/customizer/controls/typography/webfonts.php on line 128"

The two files from OceanWP and Ocean Extra seem to be almost identical.

OceanWP: 3.3.3
Ocean Extra: 2.0.3

God bless you :)
Thomas

When I look at the page: https://developers.elementor.com/getting-started/ it understandably recommends using phpcs using the WordPress coding standard but when I run phpcs on the Ocean Extra source I see quite a lot of violations.

Many are fairly trivial e.g.:

Line indented incorrectly; expected at least 3 tabs, found 0

But with so many its hard to see if there are more major ones. I’m using the current WordPress rules as far as I can see. Do you know where I can I find a phpcs rule set which matches what the Ocean extra team are doing in practice? Any pointers would be much appreciated.