Comments (15)
Yes, multi-company is not alllowed right now, but not easy either as computed field can't be multi-valued depending on the company.
from credit-control.
@pedrobaeza for my use case thats a feature not a bug, as it gives a picture of groupwide risk.
In other words, if a company is overdue with one subsidiary, it prevents them just to start ordering from another. In other words I'm not concerned with the numbers being for the company, I'm concerned they are in the right boxes.
If I make a PR that does nothing more than just consider the receivable accounts for all companies what do you think?
from credit-control.
I'm afraid it will mean more than that, as you will need to sudo other searches (at least for global coherence) and it's too much interference for you specific feature. I would say you to inherit the module and use existing hooks or propose new ones if needed.
from credit-control.
@pedrobaeza well at the very least the module should take the company_id of the partner into account rather than just a random company don't you agree. As it stands it is useless for multicompany, even if all the partners are assigned a company_id.
from credit-control.
Yes, but you have to take into account as well if company_id = False.
from credit-control.
I just reviewed the code, honestly I don't see the issue where any search will break. We are literally talking about a single in clause for a bunch of ints, all the relevant searches are already sudoed. What am I missing?
from credit-control.
I suppose you are only focusing in your specific use, not counting sales part for example. Any way, I let @carlosdauden to give his opinion, as he's the author of this.
from credit-control.
I just looked at sale_financial_risk, I want to use that as well, in fact it is the primary use.
That is a bug and a bad one anyway that it doesn't use sudo. The mere act of confirming an order on Company B, can substantially reduce risk in company A.
from credit-control.
As said, module are not multi-company, but my general thought was that it requires a total check and see possible caveats, not only changing that line.
from credit-control.
Nah, its nothing IMO, I'll just fork it and run it for a few months and see what happens. Useless to me as it is anyway and I can't see any issues with it.
from credit-control.
OK, if you say so, I haven't dug enough. If you prefer to run it on your side and then tell us back, OK.
from credit-control.
@pedrobaeza Well 6 months or whatever later, actually it works great for multicompany if you share a group wide limit. The main issue is at any sort of volume especially in anglosaxon with realtime. Lots and lots of failed transactions due to recomputes on a very broad range of irrelevant transactions but I'm yet to work out how to stop those triggers, but made some performance improvements to at least partially mitigate.
from credit-control.
Have you tried this after the improvements made in v11, v12 and v13?
#65
#66
Can you close this issue?
from credit-control.
@carlosdauden Due to disagreement about whether this was possible we have long since forked and changed this module. To be honest, it also has some performance issues as well which we needed to fix so we are quite far from this original now. Plus for whatever reason, these modules don't consider locked sale orders even if not invoiced which is an absolute must for us. But maybe looking at it , not storing the fields might fix the performance.
We are doing a v13 migration of this module at moment so we will try and integrate changes and let you know.
from credit-control.
The modules with this improvements are already migrated to version 13:
https://github.com/OCA/credit-control/tree/13.0
and there are other improvements in process:
#78
from credit-control.
Related Issues (20)
- Add hacktoberfest label to repository
- [13.0] account_payment_return_financial_risk child contact issue HOT 1
- [13.0] sale_financial_risk confirm issue with notes and sections on sale order
- [12.0] Use of self instead mail HOT 2
- account_credit_control line communication relation HOT 3
- [13.0] account_credit_control Error to render when send mail HOT 1
- [13.0] double anglo booking when validating invoice HOT 1
- account_invoice_overdue_reminder: impossible to edit Overdue Invoice Reminder email template HOT 6
- Switch default branch to 14.0 HOT 2
- account_financial_risk: "Expected singleton: res.company(1, 2)" while evaluating 'model._autopost_draft_entries() HOT 3
- Migration to version 15.0 HOT 6
- [10.0] Travis is mis-configured HOT 1
- Error de validacion HOT 1
- [14.0] Validation in `overdue_reminder_wizard` crashes: `'ir.actions.report' object has no attribute 'render'` HOT 1
- Error installing the module HOT 1
- account_invoice_overdue_reminder: include the credit notes in the process HOT 9
- account_invoice_overdue_reminder - requires admin rights to send mail HOT 5
- Migration to version 16.0 HOT 2
- [15.0] Over-risk warning requires that user belongs to group: Administration/Access Rights HOT 1
- [15.0] account_financial_risk - Error in auto_post scheduled action: Expected singleton: res.company(1,2,3,4) HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from credit-control.