Don't import PSR2 ruleset by default about phpcs-calisthenics-rules HOT 8 CLOSED

I have to remove it. It was part of original plan to include PSR-1, not PSR-2 as default.

from phpcs-calisthenics-rules.

Done. 9db4cf6

from phpcs-calisthenics-rules.

Doesn't same argument apply to PSR-1? Things like camelCase for naming aren't really part of calisthenics rules (from what I understand)?

from phpcs-calisthenics-rules.

@Rarst partially, yes.
PSR-1 should be the base line of every PHP project, and not only when really needed. I could remove it, but then I'd be forced to bring other elements to the game, such as only one class/interface/trait per file, etc.
My general sense is that if a project is not PSR-1 compliant, it's swimming against the tide.

from phpcs-calisthenics-rules.

My general sense is that if a project is not PSR-1 compliant, it's swimming against the tide.

Unfortunately there are rather large legacy projects around (cough WordPress cough).

only one class/interface/trait per file

This isn't actually PSR-1 requirement? As far as I remember all PSR's are fine with multiple definitions in file, it's just not common/convenient (Symfony does this in some places for example).

from phpcs-calisthenics-rules.

Unfortunately there are rather large legacy projects around (cough WordPress cough).

I know... I work on some too... =(

This isn't actually PSR-1 requirement? As far as I remember all PSR's are fine with multiple definitions in file, it's just not common/convenient (Symfony does this in some places for example).

IIRC, it was somehow demanded through the PSR-0 as it converted a class to be loaded into a file path. This almost surely enforces the 1 class 1 file rule, because from a vendor library, I could only include one class without loading the other.
I guess I should remove the PSR-1 requirement then... =(

from phpcs-calisthenics-rules.

Done as 5fd7ac0

from phpcs-calisthenics-rules.

Thank you for seeing it from my perspective. :)

from phpcs-calisthenics-rules.