Git Product home page Git Product logo

Comments (10)

TomasVotruba avatar TomasVotruba commented on May 20, 2024 1

Hey, thanks for awesome issue report. I got all I could ever think off! 👏

2.0 is quite old now. Could you try this with with last RC version https://github.com/object-calisthenics/phpcs-calisthenics-rules/tree/v3.0.0-RC1 please? Thank you.

from phpcs-calisthenics-rules.

wilcorrea avatar wilcorrea commented on May 20, 2024 1

Ok, I will try it ; )
Thanks for the feeback o./

from phpcs-calisthenics-rules.

TomasVotruba avatar TomasVotruba commented on May 20, 2024 1

Now things are making a little more sense because the documentation was not according to what I was using and was getting a little lost.

I'm aware of that. That usually happens, because the code here is master, but not last stable.

I sometimes send duplicated PRs and issues for what is already solved due to this :D


I'm curious... it looks like you really find these rules useful. I'd appreciate any feedback on how do you use them, where you struggle (even a little) or what could be improved.

I want this project to be as clear as possible to everyone who sees it first time and I'd appreciate your help with that.

from phpcs-calisthenics-rules.

wilcorrea avatar wilcorrea commented on May 20, 2024 1

Thanks @TomasVotruba, nope, no problems! Working pretty ; )
I will send a PR with a how-to soon, sorry the delay, but the time is not helping

from phpcs-calisthenics-rules.

wilcorrea avatar wilcorrea commented on May 20, 2024

Welll, I get the instalation with composer require "object-calisthenics/phpcs-calisthenics-rules:3.0.0-RC1" "squizlabs/php_codesniffer:3.0.0RC4" --dev after upgrade PHP to 7.1.

Now things are making a little more sense because the documentation was not according to what I was using and was getting a little lost. Thanks for the clarifications. Congratulations to everyone involved in the project!

from phpcs-calisthenics-rules.

wilcorrea avatar wilcorrea commented on May 20, 2024

Yep, I'm using into PhpStorm like a linter and it is helpful. I already use phpMD and phpCS(PSR-2) and was looking for an option to inspect Calisthenics approach. I still don't have points about the tool, but appreciate a lot that kind of work.

After restart the tests, I started with other problems. Apparently phpcs is not loading the interface of Sniffs, I believe what is because I'm using the .phar and not the files downloaded by composer. I will try get a early version of phpcs.


That is the message of error
https://gist.github.com/wilcorrea/4b25c21073a3f26ef966fa28af94aa68 (message raw)

image

That is my ruleset.xml

https://gist.github.com/wilcorrea/b63eab5df9c8a0b1e52b221327f0755f

from phpcs-calisthenics-rules.

wilcorrea avatar wilcorrea commented on May 20, 2024

The earlier download of phpcs.phar apparently is

$ php phpcs.phar --version
PHP_CodeSniffer version 2.8.1 (stable) by Squiz (http://www.squiz.net)

from phpcs-calisthenics-rules.

wilcorrea avatar wilcorrea commented on May 20, 2024

I changed the settings of PhpStorm to use the bin what came with the phpcs in require-dev and now it is working ; )

I believe I can make a PR with my experience of configure the environment to contribute with the project as soon as I can ; )

from phpcs-calisthenics-rules.

TomasVotruba avatar TomasVotruba commented on May 20, 2024

Yep, using phar is quite deprecated approach that is not compatible with this.

What did you end up with? PR with how-to for other would be awesome 👍

from phpcs-calisthenics-rules.

TomasVotruba avatar TomasVotruba commented on May 20, 2024

Closing. Let me know if these is still some issue.

from phpcs-calisthenics-rules.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.