oasislabs / battleship-demo Goto Github PK

first is chosen to be in [0, board_size - ship_length] ignoring orientation -- later we appear to be doing rejection sampling in L101-L104 based on orientation. however, at L111 when orientation is false (horizontal, if first coordinate is row and second coordinate is column) we use (first, second + tile), which means that we will never see a randomly placed ship in the last ship_length rows in an horizontal orientation.

not a framework security bug.

instead of

for x_offset in -1..=1 {
  ...
  let x = coord.0 + x_offset;

would be more natural / readable.

the if test is unnecessary because the ship is not placed on the board until L130-L134.

also, instead of using the valid boolean, this match could just continue the random-placement loop (add a label at