oamaok / ezpp Goto Github PK

Case in point: https://osu.ppy.sh/b/21010

Is your feature request related to a problem? Please describe.
When you tab out and you have a ezpp window open, it closes out.

Describe the solution you'd like
A setting to disable it closing out when you tab out of the chrome window, and adds a button to close it out when you have that setting on.

Describe alternatives you've considered
Maybe just make it so it wont close out and there is a button to close it instead of a setting

From review:

Given your extension is open source anyway, please consider not minifying the extension. This will improve review time.

when i start ezpp it sets the combo value to 0 and will reset it to 0 if you try to edit it to something else.
this goes for the miss value aswell, im not allowed to edit it.

"An error prevented the extension from working properly: html.match(...) is null"

Continuous deployment is feasible at least for Google Web Store.

https://osu.ppy.sh/beatmapsets/825377#osu/1729489

maybe use text-overflow: ellipsis

Migration guide here: https://developer.chrome.com/docs/extensions/mv3/intro/mv3-migration/

Is your feature request related to a problem? Please describe.
Currently no ctb (Catch The Beat) support.

Describe the solution you'd like
Let's port this to TypeScript: https://github.com/ppy/osu/tree/master/osu.Game.Rulesets.Catch/Difficulty

• CatchDifficultyCalculator.cs - star rating calculator
• CatchPerformanceCalculator.cs - pp calculator

Currently, the taiko calculation codes are in ezpp repository, instead of its dedicated repo/package.
I think we can create another repo for these calculation codes.
If we don't publish the package to npm, then we can do yarn add oamaok/new-repo to add a package that is from a github repo.

you can find calc here http://maniapp.uy.to/

Hello,
I have an idea of enhancement, If possible, add the bpm of the map when we select DT mod, it'd be really helpful :)

I hope it can be done :D

Thanks

Adding some basic end-to-end tests for the extension would be great.

puppeteer is usually great, but it unfortunately lacks the ability to test extension popups. It could still be usable, though, if the chrome API calls were mocked and the whole extension accessed as a standalone web page.

ezpp is no longer available on the Firefox addons site, meaning it cannot be installed on Firefox without compiling. please put it back on firefox addons.

The URLs have changed since the addon was released and don't work on the new site anymore.

Is your feature request related to a problem? Please describe.
it's currently possible to calculate only pp, not star rating. It means we cannot get star rating for like DT, HT.

Describe the solution you'd like
Add complete support for taiko, including HR, DT, HT, EZ

Additional context
I'm currently working on it, and it has around 700+ lines of new code for now.
It might take a while to fix bugs.

Using git tags for new versions in the history allows users to easily identify which version of the source code is in the add-on stores and lets users check what the latest version is.

Displaying a calculated value instead of the 0 that's given by the website would nice. Perhaps it would be colored yellow or in parentheses or something like that to indicate that it's not an official, effective value.

this is my fault, I forgot to cap the cs bonus (which is probably how it worked prior to the high cs nerf after WWW's 600pp score)

see this commit Francesco149/oppai@0b028e6

it fixes extreme overrating of maps like https://osu.ppy.sh/s/347136

On converted maps, it shows the original (std) star difficulty instead of the converted map's (taiko) star difficulty. (because of this, it shows incorrect pp on most converted maps)
For the max combos, use the original one for now. (converted maps does not contain max combos in JSON, causes empty max combo field and NaNpp)

Additionally, normal taiko maps' max combo = circle count but converted maps seem to works differently.

ezpp is still using ojsama 1.2.5, and so it is not showing correct pp values that correspond with the recent pp changes.

Noticed ezpp got an update with an additional number next to the BPM, which I'm assuming signifies AR.

Either way, this number seems to be accurate with AR changing mods like EZ, HR, DT, and HT, but without them, it always says the AR is 11. I tried this on multiple maps, but it always seemed to have this issue. Hopefully it will get resolved soon.

When showing the popup, this appears in the console:

The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol.

Initial implementation in this PR #70

Somewhat accurate calculator can be found here: http://pp.mon.im/

Since last update that integrated the BPM of the map, it increase when we put DT but it's not decreasing when we put HT

I would like to have the project mostly use the functional programming paradigm instead of object oriented.

When I open the browser-bar window I'd love to be able to toggle mods with the same hotkeys as ingame

Is your feature request related to a problem? Please describe.
Currently no mania support.

Describe the solution you'd like
Let's apply the initial Taiko calculator solution and use this: http://maniapp.uy.to/

The developer of oppai released a vanilla JS rewrite of oppai called ojsama which returns the same results as native C oppai.

This could be used to replace the current calculation as it's quite inaccurate.

Everything is said in the title.

I know the extension may not have too many strings to translate, but it would be nice to have the option for people that don't know much of English. Anyways, I'm available for Spanish translations if needed.

Not sure exactly what's wrong, AR is displayed as 11 without any mods and then displayed correctly with 1 mod, but not correct with multiple mods

convert , to . (comma to dot)

Also when you type slowly then it delete the dot and you need to type it again, and if you still slow and type dot again it repeats infinite.

Length, bpm and AR are currently unlabeled. They are only accompanied by a little icon which conveys too little info. A title="" attribute should be added to the tags. Alternatively a tooltip solution?

Referring to this: https://github.com/oamaok/ezpp/blob/main/popup/index.ts#L366

Let's create a type, not a class.

The bug

The extension fails to load and shows this error in console: Unchecked runtime.lastError: Could not establish connection. Receiving end does not exist.

As I wrote in index.js, it happens randomly. (no consistent reproduce steps)

Workaround

Reload the page

Can you please update the plugin with the new translations?

Base AR is 7.5 here and it shows 14.1 with HT

The reduce here can be replaced with usage of .replace method's callback.

From review:

-- webpack is making it hard to review. A simple diff shows differences between the uploaded and generated xpi, I had to check the diff in detail to see that webpack was just flipping around some conditionals.

The pp calculation and SR seems outdated. Yeah IK without updated one we can still predict how much pp that we can get from a map, but I guess it is better to update it