Bodyless response about oak HOT 8 CLOSED

Yeah it presumes there is always a body, which isn't a good assumption.

from oak.

I did some digging and it seems oak is handling empty body properly:

async listen(addr: string): Promise<void> {
    const middleware = compose<Context<S>, S>(this._middleware);
    const server = this._serve(addr);
    for await (const request of server) {
      const context = new Context<S>(this, request);
      await middleware(context);
      console.log('post middleware');
      const srvRes = context.response.toServerResponse();
      console.log('post src res', srvRes);
      await request.respond(srvRes);
      console.log('responded');
    }
  }

If you respond with empty body responded is printed to console, I suspect problem is in serve from deno_std. TBC

from oak.

Sorry @kitsonk, this is issue from deno_std. denoland/std#52

from oak.

Yeah. I had narrowed it down to there too. Let's leave this open, because will need to bump the dep once resolved.

from oak.

Actually we can set content-length to 0 in oak.

from oak.

I think it's a good idea, will get it working for now. I'll see to proper handling in standard lib.

from oak.

Yeah, I think in the toServerResponse is the content-length is missing and there is no content-encoding and no body, the setting it should be fine. I think if there is user set content-encoding then they may be doing something like streaming a file.

Based on that, it is arguable if http should std should actually support it as really it should leave all those concerns up to implementors.

from oak.

Agreed, but as we can see now if body is not supplied server just hangs, I believe http.serve should handle such cases nevertheless instead of hanging. I'll just implement it anyway 👍

from oak.