Comments (2)
NfNitLoop
commented on August 22, 2024
Update: One of the great things about [Async]Generators is how composable they are. Unfortunately, that means my proposed workaround may work in fewer cases than I thought, and doesn't work in mine.
While the core of my logic does look like my renderData() example above, it's wrapped in another layer, that looks like:
//pseudocode
async function * pageBoilerplate(pageContents) {
yield `<!doctype html>\n`
yield * otherPageBoilerplate()
for await (const item of pageContents()) { yield item }
// etc.
}So a peekable is only going to get that <!doctype html>. and none of the actual page logic. 🤷♂️
I may need to rearchitect things a bit to avoid this bug.
from oak.
NfNitLoop
commented on August 22, 2024
🤦 Nevermind. The "connection being left open indefinitely" issue was not due to oak's handling of AsyncIterables, it was because I had code that was waiting forever in my own logic.
A simple test like this shows that Oak does close the connection when an AsyncIterable throws:
function example({response}: oak.Context) {
const body = async function * renderBody(): AsyncGenerator<string> {
yield `First\n`
yield `Second\n`
console.log("Got here")
throw new Error(`Error while rendering body`)
}
response.type = "text/plain"
response.body = body()
}It is still true that this exception doesn't get logged by the documented error logging pattern, but we can open that as a smaller issue w/o all the unrelated context in this ticket. Sorry for the noise!
from oak.
Related Issues (20)
- Use body and relay it via proxy middleware in oak v13+ HOT 1
- Proxied request secure?
- Controllers, why doesn't possible inject with private?
- More typing on Request and Response object? HOT 4
- request.body.text() causes error on localhost HOT 3
- Oak import causes a compiled app to hang HOT 1
- context.request.body is not a function
- How to gracefully exit, when Bun Server does not adhere to AbortSignal? HOT 2
- ctx.request.body is not a function
- Application's State type error HOT 2
- A better way to handle pre-processed bodies by zod / joi / yup / ajv
- Use `:authority` psueod-header on HTTP/2 if available HOT 4
- Support `Forwarded` header as well as `X-Forwarded-*` HOT 1
- `deno emit` does not support dynamic imports and npm dependencies so can't be used with oak HOT 1
- Error handling doesn't work HOT 8
- Body limit in oak@13+ HOT 1
- Property `Context.Params` does not exist HOT 1
- Property Context.Params does not exist HOT 2
- How to upload a file from the client or from postman to the server?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oak.