nyxpay / nyx Goto Github PK

Hello.

I have issue i added your coin to my pool but i have no idea why its not paying to the miners automatically,
It shows that they payments is fine every two hours but in real not paying the balance in the pool wallet still.

I hope anyone can help me with this issue

Best regards,
frrsan pool team

Accounts should NEVER be able to have a negative balance. This can happen like this:

Account "" has 0.0000 NYX.
$>nyx-cli move "" "other-account" 1000

Ends up like this:
$> nyx-cli listaccounts
{
"": -1000.0000000000
"othe-account": 1000.000000000
}

This is "magic" like only fiat banks do... making crappy money out of nothing! This problem happened for real by using:
$> nyx-cli sendtoaddress [nyx-address] 1001.00

Crapped up my whole wallet showing negative balances and wrong amounts. Only getbalance was showing correct "total" amount as negative and positive balances of all accounts were correct.

This is a crappy behaving that should not happen! I don't see any reason why zero accounts should be deducted for any transaction. The correct behaviour would be to give an error if trying to use default account "" if it is zero or as less balance. Same for sendfrom command while trying to send coins from given address that has zero or less amount that should be transfered.

In my case this happened while trying to transfer coins between local addresses (masternode setup).

Today I've setup a second masternode. I've done the usual way:

• Creating second account/address "mnode2"
• I've send single-transaction to mnode2-address
• I've create masternode genkey
• I've updated masternode.conf (added second alias/line using: alias, ip:port (same as mnode1 in first-line), masternodeprivkey and colleteral-output

I've been using same IP:PORT on both nodes! The first node (which got POSE_BAN now) was running fine for month now!

I really would like to understand what the problem is. Isn't it allowed to use same IP:PORT for multiple masternodes? If so why is there no "warning" in the client?

Please let me now so I can fix this and hopefully can restore the node to become ENABLED again.

Account "" is shown in listaccounts. But trying to use it with nyx-cli for commands like:
$> nyx-cli getaccountaddress ""

or trying to use it as source/target for:
$> nyx-cli move [from-account] [to-account]

ends up with a Deprecation-Notice.

In my case this was a real problem while I screwed up my local wallet like described here #1.

I've been testing to setup two masternodes by adding a second masternode in masternode.conf. I've used two different IPs, new genkey, new output-tx-hash and so on. Everything looks fine in first glance!

But only first masternode get's up "ENABLED". Second masternode keeps struggling in "WATCHDOG_EXPIRED" or "PRE_ENABLED"-State. I've tried restarting daemon - without luck until now after waiting some days for a change on this state.

Sentinel is running fine for first masternode. Does sentinel require anything to work with second masternode? In nyxcoin.conf only the first-masternode privkey is entered. Also tried swapping it against the one of second masternode - without success until now.

I've disabled "external_ip" in nyxcoinf.conf. TCP is listening on second masternode-ip and port 4330 correctly. External connection to this IP/Port also works fine. Debug.log mentions some broadcasting to Masternode-List for second-masternode IP/Port as well.

It's not understandable why second node keeps in un-enabled state as everything looks well.

Why masternodes for onion-network only blocked? I noticed some other coins/masternodes like dash, pivx and so on explicitly allow using TOR-Network only masternodes.

1. https://github.com/PIVX-Project/PIVX/blob/master/doc/tor.md
2. https://github.com/dashpay/dash/blob/master/doc/tor.md

NYX seems basically to implement (fork?) the same features used there. But any non IPv4 and IPv6 address (like Onion-Address) is blocked and giving "Masternode not capable" or "Invalid IP Address".

Is this a desired limitation or a side-effect of the IP Address validation in the code:

1. nyx/src/activemasternode.cpp

   Line 143 in 30ba1ed

   bool fFoundLocal = GetLocal(service) && CMasternode::IsValidNetAddr(service);

2. nyx/src/masternode.cpp

   Line 267 in 30ba1ed

   bool CMasternode::IsValidNetAddr(CService addrIn)