nwrkbiz / cpp-supportlibrary Goto Github PK

There are several warnings in JSON.h when compiling it (alone) with VS2019 (c++17):

3>...\JSON.h(907,40): warning C4244: 'return': conversion from 'const __int64' to 'double', possible loss of data
3>...\JSON.h(915,60): warning C4101: 'e': unreferenced local variable
3>...\JSON.h(918,56): warning C4101: 'e': unreferenced local variable
3>...\JSON.h(954,40): warning C4244: 'return': conversion from 'const double' to '__int64', possible loss of data

Ideally there should be no warnings at all during compilation - the project using the library may be set up with the option like 'Treat warnings as errors'

I wanted to retain the insertion order for object properties. Here's my modified code: https://gist.github.com/connorjclark/ab8dcd91b411e9b86e1c6be9737d75f9 . It uses a vector to track the order, and provides custom iterators to read the map in the order defined by the vector.

Seems to work so far. Obviously results in a performance regression. But might be useful for others so I'm sharing. Maybe there's a way to make this configurable?

Objet.toUnescapedString() does not fully use unescaped versions of the Object.

I would like to offer a branch fixing this.