nvision-commerce-solutions / module-core Goto Github PK
View Code? Open in Web Editor NEWCommerce 365 for Magento - Magento 2 Extension - Core Module
module-core's People
Contributors
Watchers
module-core's Issues
getCustomerId() method in Helper/Data seems wrong
Hi there
There seems to be some problems in the Helper/Data.php file, I think the method getCustomerId() might not work as expected.
Running phpstan on level 1 found the following 3 problems:
------ -------------------------------------------------------------------------------------------
Line module-core/Helper/Data.php
------ -------------------------------------------------------------------------------------------
49 Access to an undefined property Commerce365\Core\Helper\Data::$customerSession.
53 Access to an undefined property Commerce365\Core\Helper\Data::$httpContext.
53 Access to constant CUSTOMER_ID on an unknown class Commerce365\Core\Helper\ContextPlugin.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
------ -------------------------------------------------------------------------------------------
I have the impression this method getCustomerId() is obsolete, not used, and can be removed entirely?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.