RHEL7 inconsistency between the file mode of ld.gold.nvidia and the defattr about yum-packaging-precompiled-kmod HOT 6 CLOSED

Okay, from http://ftp.rpm.org/max-rpm/s1-rpm-inside-files-list-directives.html#S3-RPM-INSIDE-FLIST-DEFATTR-DIRECTIVE

%defattr(<file mode>, <user>, <group>, <dir mode>)
%attr(<mode>, <user>, <group>) file

It seems the solution would be to add a %attr line immediately after %defattr

%files
%defattr(644,root,root,755)
%attr(755,-,-) %{_bindir}/ld.gold.nvidia.%{kmod_driver_version}/ld.gold

To match up with the system defaults, i.e.

$ ls -l /usr/bin/ld.gold 
-rwxr-xr-x. 1 root root /usr/bin/ld.gold

from yum-packaging-precompiled-kmod.

thanks @kmittman, do you want us to file a PR with that proposal or will you instead own making the changes?

from yum-packaging-precompiled-kmod.

@kmittman I went ahead and filed a PR with what is discussed here.
Perhaps it needs to be a new branch 516? Depends on your release process.
I tested it locally an it seems to attempt adjusting the mode of the right file indeed.

from yum-packaging-precompiled-kmod.

Hi @txangel thank you for the pull request, can you please sign the commit(s), see: CONTRIBUTING.md. Optionally, perhaps consider squashing the commits?

I can try to back-port the change but not sure what release(s) the fix would make it into, as there are cut-off dates for each branch.

from yum-packaging-precompiled-kmod.

@kmittman I think the commits are squashed and the description is now signed according to the guideline (#38).
Is that all good now?

from yum-packaging-precompiled-kmod.

Closing, #38 has been merged

from yum-packaging-precompiled-kmod.