Git Product home page Git Product logo

nunchuk-desktop's People

Contributors

bakaoh avatar barontongnunchuk avatar hugohn avatar tongvanlinh avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

nunchuk-desktop's Issues

Error creating wallet with same 3 keys as previous one: "To create new wallets, additional XPUBs from the key are needed."

I created 3 software keys on 3 different devices (2 androids and 1 laptop) for my account, and then was able to create a wallet using those 3 keys as signers. But when I try to create a second wallet the same way with those same 3 keys, I get the following error on windows 11 laptop: "To create new wallets, additional XPUBs from the key are needed."

On the Android devices it throws this: "Run out of cached xpub!"

Trezor with 25th word passphrase not imported

When adding hardware key with trezor one device it asks for passphrase but entering only disables passphrase on device, so cant add a hardware seed with 25th word passphrase with this device, in specter desctop and sparrow this is no problem for trezor one.

Graphic size / scaling is unusual, (Windows)

image

What could fix the problem is for the wallet to start on the same screen position that it was closed.
Right now it's always starting in the middle of my laptop's 4k screen that has 200% scaling.
Text is small but readable, if I move it up to my large 1:1 scaling monitor the resolution is halved and hard to read.

The way to fix it on user side is to right click the icon / Property / Compatibility / Change High DPI settings / High DPI setting override / Set to System

image

Send to address does not show entire address.

I noticed that when I create a transaction, right before I actually sign the transaction the "Send to address" field truncates the actual address. There is a scrollbar, but it seems to not work. The only way to see the entire address is by clicking on the address, which brings it up in a new window. The problem with this method is that if I already clicked "Sign" I'm not able to actually view the address to verify it on my hardware wallet.

The only good way to verify that I'm sending to the correct address is by viewing the address before I actually click sign.

I did notice that when I create a tx with another multisig wallet the send to address happens to be smaller so it doesn't have this issue. The address I was sending to when I had this issue was to a multisig, are multisig addresses longer?

Here is a screenshot of the issue:

Screenshot 2023-06-29 at 10 21 32 AM

Details on my setup:

  • MacOS Ventura 13.2.1
  • Nunchuk version 1.9.20
  • Using ledger nano s as my signing device (hardware wallet)
  • Singlesig wallet
  • testnet

Build failures on macOS

Hi,

first of all, thanks for making the code available. I'm trying to build the code on mac os, but was running into various build problems.

Looking at https://github.com/nunchuk-io/nunchuk-desktop/blob/main/nunchuck-client-qt.pro#L59, the instructions try to pull in code from contrib/nunchuk-client, but the submodule is named contrib/libnunchuk. There are various other places in the build script that refer to nunchuk-client.
contrib/nunchuck-client/include/nunchuck.h \

Is there newer code available that already fixes this?

Multi Device Wallet does not sycn signed transactions

Hey i just created a multi-device wallet as suggested by your website nunchuk.io here: https://resources.nunchuk.io/getting-started/multidevicemultisig/
I perceded as follows: i set up one desktop nuchuk client with one airgapped key and two other keys on 2 different mobile nunchuk android wallets.
I only imported one dirfferent key on each device, they all synced and the collab wallet showed the correct balcance/ transactions.
So i could open the chat with myself, and set up the multi device test wallet, but when trying to transact the signitures don't sync at all, i signed the same transaction in chat on each device, but the signitures dont sync.
I am connected to my own node.

Deleting primary account is not permanent

Hey, I found a new confusing issue:
On one windows machine in primary key account first I tried to set network on mainet within nunchuk to core RPC connection just to give it a try (always used electrum server on my personal node before) .
After that, whenever I tried to log in to this particular primary account the app totally crashed.
I could not log on anymore at all. So after that I decided to do a clean reinstall of nunchuk without any data, but somehow it seems to still remember the core connection for this particular windows account I'm using, since every time I try to sign in it gives me a "send request" error. On the very same machine, other windows user account I can perfectly set up the same primary account and log on, as well as on android. No problem. But somehow it keeps getting the error on my main windows user account even after deleting all the user data completely and unistslling/ reinstalling nunchuk.

Then furthermore and even more strange I decided to completely delete this whole primary account within nunchuk, since I did not need it, just wanted to move to a new one. So deleting worked fine and the account was gone completely. When trying to log on it just said user not found.

But now after some days to my surprise the primary account was back online! So somehow it came back even after confirmed deletion within nunchuk, I could log in again after some time. So magically the primary account was back. I deleted one more time to be sure. Everything was gone, deletion succesfull, but after some days it was back again...
So it seems somehow could it be the backups of your servers keep mirroring these accounts back from some backups like raid systems or something? It´s not good feeling that once you set up an account you can´t really delete it anymore.
All other keys/ accounts work fine. Just wanted to let you know about these issues.

Allow to set Derivation path of wallets

Hey guys,

I am trying to import my wallet using BSMS but it is more challenging than I thought (signature and so), however if they UI allowed to set the derivation path of a multisig wallet this problem shall be solved, I need to import a wallet with m/84'/1'/0' but it looks like that nunchuk sets them to m/48'/1'/2

program does not fit on the screen

Hi, I am using MXLinux latest version on my laptop. The size of the program is larger than the laptop screen. I tried to maximize, resize, full screen, but I can't solve it. The application is unusable.

Nunchuk desctop open GL Error

If i try to install Nunchuk Desktop on Windows 10 i always get this error:

NunchukClient

Failed to create OpenGL context for format QSurfaceFormat(version 2.0, options QFlagsQSurfaceFormat::FormatOption(), depthBufferSize 24, redBufferSize -1, greenBufferSize -1, blueBufferSize -1, alphaBufferSize -1, stencilBufferSize 8, samples -1, swapBehavior QSurfaceFormat::DoubleBuffer, swapInterval 1, colorSpace QSurfaceFormat::DefaultColorSpace, profile QSurfaceFormat::NoProfile) .
This is most likely caused by not having the necessary graphics drivers installed.

Install a driver providing OpenGL 2.0 or higher, or, if this is not possible, make sure the ANGLE Open GL ES 2.0 emulation libraries (libEGL.dll, libGLESv2.dll and d3dcompiler_*.dll) are available in the application executable's directory or in a location listed in PATH.

OK

Database encryption does not work when signed in

In windows app, when signed in to a nunchuk account, I go to settings and select encryption, i can set a passphrase for signed in account, the encryption gets set, keys get encrypted, but when I sign out/in in again it does not promt the passphrase for encryption, then it can not read the keys anymore.

When in guest mode, encryption works fine! It asks for passphrase and key data is stored in an encrypted way in the folder App data roaming..

Otherwise the only way to use nunchuk is my seedwords get stored in clear text! That is not an option at all, cause you have a digital copy on windows accessible for all apps!

Can't open application on Mac

Hi,

I'm running on a Mackbook Pro with an M1 processor. The OS is Ventura 13.3.1. I recieved the following error when attempting to open the app: You can't open the application "Nunchuck" because it may be damaged or incomplete. Any suggestions on how I might get this working?

image

Cannot copy xpub from Key info screen

Details on my setup:

  • MacOS Ventura 13.2.1
  • Nunchuk version 1.9.20
  • Using ledger nano s as my signing device (hardware wallet)
  • Singlesig wallet
  • testnet

When clicking into your key from your wallet info page it brings up a key info page that shows your xpub, however there is no way to copy your xpub, also when you cmd+c it does not copy to your clipboard.

Scanning of keystone qr fails

If I scan a signed transaction airgapped with seedsigner it fails to scan and an error message pops up, within mobile app it scans/ signs successfully with same signer though. It seems to try multiple times on android and only once on windows, hence it always fails to import the signed transaction...

Unable to add new hardware key

I provide

  • Key Name
    somekey

  • XPUB
    xpubkjnkjnkjnkjnkjnkjn......kjnkj

  • BIP32 Path
    m/48'/0'/0'/2'

  • Mater Key Fingerprint

and then I see this error.

Could not create remote key: [-2007] UNIQUE constraint failed: REMOTE.PATH

Screen Shot 2021-12-03 at 4 40 06 PM

Signing in with primary key fails

In Version 1.9.18 and Version 1.9.19 signing in with a primary key does not work anymore.
It used to work in prior versions just find, now after entering the primary key passphrase it doesn't do anything anymore...
In that account I am connected to my node.
Strange enough if i enter my credentials for primary account first and then go to guest mode it seem to be logged on as primary account....

[FEATURE REQUEST] increase gap limit (BTCpay server compatibility)

As a privacy measure, BTCpay does not reuse addresses but doesn't choose consecutive addresses, this means that when you import into Nunchuck a wallet that has been used by the BTCpay server, it does not show all UTXOS or fail when you try to import a PSBT generated by Sparrow with UTXOS out of scope of Nunchuk (Sparrow already integrates the limit gap).

Nunchuck fails or doesn't show all UTXOS. This becomes an especially important problem in multi-signature wallets to be able to speed up the signatures and be able to do it, especially from the mobile version, but would be great on desktop version as well.

Do you have in the roadmap to incorporate this feature?

Thanks

issue already opened for the mobile version: nunchuk-io/nunchuk-android#13
ref of other requests: BlueWallet/BlueWallet#3398

Max Spend = Insufficient funds error

Occurs on both Nunchuk-Desktop and Nunchuk Mobile thus issue possibly with libnunchuk.
Nunchuk Desktop version: 1.9.11

When attempting to sweep a wallet, I encounter the following error:

Could not create transaction [-1011] Insufficient funds wallet_id= 'h78wveve'

This is directly after creating a tx with a 1 sat/byte fee rate and it still pending confirmation.

Either the max spend should work, or a better error message should be presented with instructions on what to do.

Wrong path installation for dmg packages

Last 2 release the dmg packet try to install to /System/Applications and this directory is restricted, the dmg package should go to /Applications ; also have .fseventsd folder and it should not be there

image

Apple M support?

Hello there! Thank you very much for your wonderful work!

Is there a nunchuck release for apple silicon that does work without rosetta, or any ETA?

Thanks in advance!

Rust-miniscript descriptors import

Hello,
I tried to import into nunchuck, and I failed, a descriptor of the form

wsh(t:or_c(pk(02a7d30ac6b0cd55b6868f5a65aff1dbdaa18f4315fe04de809fffb2899340ae0f),v:multi(1,tpubDBpAoACBVTeZGGeyQdjgHWCJC8hjfMHAwbkCfqnagyNHdkQKA8uTj3SpscLKzQ1SUjgzdih7uQji3uPwAaWjZT9GXECoUUqCNA5JXPvyNZm/1/1/*,02f17cce1778c101e3b0ac5c76997af3752b0a221b1ebffc23af679328f3f5d6fc,02350b5a9a12df96579d150f3f751de416e58a67f2ba9bc99f6964b7a48a79042b)))

which is valid in rust-miniscript library. Basically it does OR ( Masterkey, MULTI(1, KEY1, KEY2, KEY3) ).

I assume that by the Nunchuck such descriptor is considered as non-standard and wallet wont work with it, right? Do you have any plans about supporting arbitrary miniscripts?

Cancel TX on mobile does not import to desktop version

Canceling a signed Transaction does work fine on desktop, it gets imported to Nunchuk mobile (android) just fine.
But if a "ready to broadcast" TX is canceled on mobile (android) it does not get canceled in desktop version, even after restarting the desktop app.
I would have to cancel manually as the desktop user.

Can not log in anymore to primary account in version 1.9.20

Hey, I just saw the newest release from 2 hours ago. In that version i can´t log in anymore after entering the passphrase for the primary account, it just remains on that screen, nothing happens, no log in...
i remember there was a similar issue in a prior version, dont remember which one it was...

Transactions displayed incorrect in wallet history

Currently I am connected in guest mode to my own electrum server.
In my recent transaction history I have two outgoing transactions which where broadcasted by specter desktop and memepool.space , they where both replaced by fee to bump the fee.

So now in Nunchuk desktop it does not display/resolve the recipient address of these transactions, it says only "unknown", and only the fee trancation is visible like 0.00001463 btc, but the actual transcation of 0,034 btc is missing completely.
Even after force refeshing the wallet, it stayed the same.

When using sparrow or specter desktop wallet, connected to the same node, it is displayed correctly.
Also if I use nunchuk android the outgoing transactions are listed correctly. But in desktop app it's missing.

health check error

Could not health check key: [-3003] Malformed base64 encoding.

error occurs after executing Run Health Check button

-signing message .txt file using SD card
-bip32 path is m/84'/0'/0'
-hardware device is a Foundation MK1
-the hardware wallet appears to attempt to
sign with m (is this the problem?)

Pending Wallet Error in Version 1.9.21

Hey Tong, I finally had time to install the new pre-release version 1.9.21.

Looking very good,
neat design! But when signing in on windows, primary key account, collab wallet 2/3 wallet, airgapped keys, I get the following error message on main screen ( see screenshot).

It says pending wallet (But is finalized), but if I click on the pending wallet, it displays the wallet correctly as usual ( Wallet Name, TX, so on, see 2nd Screenshot), otherwise, no errors on collab signing with messenger, as long as I set up the wallet fresh from scratch.
When using old database i could not log in to account (reported that issue, also had this error in prior versions), but with fresh database, no errors, and all signers work, multisig reconstructed, no problem.

Nunchuk10-23

Nunchuk2

On desktop I am using my own electrum server backend.

"Stay signed in" not working (on Linux)

When I reopen the app, it is always signed out.

I tried manually editing NunchukClient.conf, and set keep_logged_in=false to true, but it will set it back to false even when selecting stay signed in on the login screen.

Multiple Outputs

It would be nice to have the option to send to multiple outputs in a single transaction like BlueWallet allows. Would like to use Nunchuck as a collaborative multisig between business partners and it would be nice to pay out to each shareholder in a single transaction to save on block space and fees. It would be awesome if this feature could be added to both mobile and desktop.

Small bugs, improvement proposal

Although nunchuk desktop is working really great now with all sync and signing devices, I still miss some small improvements, wich could be important for unexperienced users:

When entering passphrase, it would be convenient to just hit the return/enter key to log in, this still does not work, you would have to click login button.

When copying a bitcoin address from another app and paste it in nunchuk, the right click mouse don't give the menu/option to paste, you would have to use keyboard shortcuts like ctrl/V to paste, which really not every user is familiar with...

Seed entry needs improvement.

When entering a word, the whole word has to be typed or keyboard/mouse has to be used to select the right word.

What it should do it auto-select the closest word, so that after 4 character the TAB or Space key can jump to next box.

Also there's an issue where autofill find words containing the string instead of starting with.
Example, The world is "identify" but typing "ident" brings up "accIDENT"
image

Since no words contain a space character, the space key should jump to next box.

Copy pasting a seed with spaces could fit in all the boxes.

24th word could have the option to be calculated to be compatible with offline entropy generation.

image
When a seed fails the checksum it should stay filled so that it can be reviewed for errors.

Transactions missing in Wallet history

When signed in to guest mode, my main wallet only shows the transactions from this year(2022)!
Transactions from 2021 are missing in wallet history under -->show all transactions
This happens no two different windows machines. Wallet balance is correct.

On Android it shows the transactions correctly.

Backup Wallet File from iOS wont import into Linux Desktop App

The 1.9.4 iOS client's exported BSMS wallet backup file does not import into the linux desktop client. The root cause is that iOS saves it in a windows format line endings CR/LF and Linux just has LF line endings. If you convert the iOS file to Linux LF line endings then the import works.

Missing transactions when exporting wallet from iOS to macOS using Bitcoin Core

Hi, I recently tried out Nunchuk 1.9.20 on an M2 Mac Mini running macOS 13.5.2. I'm using guest mode and I exported the wallet config I use on iOS into the Mac version of the app via QR code. I then configured Nunchuk on Mac to use Bitcoin Core 25.0.0 as its syncing mechanism. Upon syncing the imported wallet no transactions were displayed. Then upon forcing a resync in the network settings of Nunchuk I had two transactions appear but one remained missing.

Both visible transactions output to receive addresses owned by the wallet whereas the missing transaction outputs to a change address owned by the wallet. I've tried what I can to get it to appear using Bitcoin Core but I'm having no success. My Bitcoin Core instance is running locally and Bitcoin Core shows all three transactions. Every setting in Bitcoin Core is at its default apart from the following:

# Core
mainnet=1
txindex=1
assumevalid=0
blockfilterindex=1
coinstatsindex=1
#blocksonly=1

# RPC
rpcallowip=127.0.0.1
rpcauth=[REDACTED]

# LAN
#connect=[REDACTED]
addpeer=[REDACTED]
addpeer=[REDACTED]
addpeer=[REDACTED]

Linux install fails Ubuntu

I tried to run the App on Linux Ubuntu focal fossa, Appimage of the new Version creates Errror, some shared libraries are not found. Old Version 1.9.9 works. New one does not start. On Windows Nunchuk is the only app, wich does not start but produces several Open Gl Errors.

Nunchuk regtest support

Hi again!

Is it possible to run nunchuk on a regtest with segwit multisig wallets?

Thanks.

Support BIP21 for generated addresses

Currently when generating an address on Nunchuk it just generates a plaintext address that does not use the BIP21 URI parameter bitcoin:.

Using BIP21 would help make Nunchuk more interoperable with other wallets and assist with supporting initiatives like unified qr codes.

Can't execute the AppImage

On Kubuntu 22.04, I dezipped the downloaded file for Linux, then the execution of the .AppImage does not work.

The file is executable. Other AppImages work perfectly.

nunchuk-linux-v1.9.13.zip
nunchuk-linux-1.9.13.AppImage

Peach Bitcoin QR Codes Not Working

Hi, the latest version (1.9.22) on macOS seems to fail to properly parse the escrow QR codes generated by Peach Bitcoin. When scanned the address and amount values aren't extracted, instead the contents of the QR code just get dumped into the "TO ADDRESS" field. I've attached an example that you can try yourself.

Screenshot 2023-11-01 at 15 54 03 2
image

account login and wallet store identifier zero balance

Successful login with zero balance can occur if the field "email address" is populated with upper case.

OS: Linux
Version: Desktop 1.9.6 appimage

Steps to reproduce:

  1. create an account for [email protected]
  2. Create Keys, wallets etc under that account ID.
  3. Log out.
  4. log in with [email protected]. (note the capital letter)

Result: login is successful but keys, wallets and balances are missing.

Likely the result of how the wallet is stored in the file system via a hash of the email address. When the email address is valid with a capital letter or the reverse then the hash also changes and the wallet is empty even with a valid login.

Unable to create wallet

I tried creating a one-time escrow wallet but failed on the last step with an error: Can not create Wallet: [-1001] invalid address

  • One-time escrow wallet
  • Two signers
  • Native segwit address
  • 2 of 2 multisig

image

Error to add Hardware key

When I try to add my ledger nano X key to the app show me this error when try to add the key

image

this message is just after this screen

image

Notes:

  • on the device don't appear nothing to sign approve,
  • the hardware Key work property with sparrow wallet in same computer

MacOS Ventura 13.3.1
Nunchuck Desktop 1.9.17
Hardware key : Ledger Nano X

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.