Remove usage of `unsafe` completely about decancer HOT 9 CLOSED

I'm afraid this is a wontfix, sorry.
The SAFETY comments and lots of testing should suffice!

from decancer.

Sooo i've removed all unsafe code in the Rust, WebAssembly, and Node.js crates today! Some unsafe still persists in the Java and C/C++ crates as they are a cdylib in nature.

Feel free to give me feedback on the current codebase! @GnomedDev @Milo123459

from decancer.

A new release should be out later this month!

Thank you all for the advice! I will be more cautious with unsafe code. I apologize for closing this issue prematurely! ❤️

from decancer.

Would this be possible though? Because the crate also reads from a custom-made binary - which wouldn't be possible without some pointer arithmetic.

from decancer.

As seen by #24, safety comments and testing without miri will not make unsafe magically safe. I'm preparing a PR to remove the trivial unsafe, is there an acceptable performance loss or must it be 1-1? @null8626.

from decancer.

Hmm, alright then, do as you please!

A slight performance loss is fine.

from decancer.

Hai! Any updates on this?

from decancer.

I think the next step would just be publishing a new release :)

from decancer.