nubeio / common-py-libs Goto Github PK

requirements.txt should only contain the shared libraries between all nube-io python projects.
Each other project should install its own requirements in this folder from its script.bash

• BAC0
• bacpypes
• pymodbus
• influxdb
• pyserial
• and any others that are only dependant to one project

example bash lines to install its own requirements for other projects:

echo -e "${GREEN}Installing requirements in ${LIB_DIR}...${DEFAULT}"
source ${LIB_DIR}/venv/bin/activate
pip install -r requirements.txt
deactivate

• NubeIO/rubix-service#32: Then following up action
  • Use command in binary to start
  • Remove all bash.script in every repository
  • When wanting to install/register app as service, provide service template to run and/or add option in REST
  • Remove token in linux service file. Introduce GitHub token as option in REST /download, and able to add token as permanent in database/text by another REST :PATCH /token
• Check rubix-bacnet-server and rubix-point-server binary to ensure BAC0 without panda can work, because VirtualPoint needs it but I don't know which part in these projects implement it. @NubeDev
• Fix logging should extends from gunicorn. But IMHO, it is unprofitable function because only send log from one app to mqtt. I recommend don't waste time for it, many options available, aka: stream syslog directly to influxdb.
• Don't introduce setup.py, because poetry can do it pretty well. See poetry packages. And I don't see benefit for that @Shiny380
• Correct VERSION file path. It is wrong implementation and crash /ping resource
  https://github.com/NubeIO/lora-raw/blob/d2051191ed57c15f863c5745bf85779433e5c998/src/resources/ping.py#L10-L11
  I just fixed it temporary, but should have workflow to bundle VERSION file and read it in binary later
  https://github.com/NubeIO/lora-raw/blob/902f4a585f6042b27919f1d3da639ace0302ba12/src/resources/ping.py#L11-L15
• Use influxdb-client-python instead of influxdb-python if current influx database version > 1.8.0

  curl -i -X GET 188.166.208.225:8086/ping
  HTTP/1.1 204 No Content
  Content-Type: application/json
  Request-Id: 1cdd06d6-4923-11eb-9efb-0eb3c650dce6
  X-Influxdb-Build: OSS
  X-Influxdb-Version: 1.8.1
  X-Request-Id: 1cdd06d6-4923-11eb-9efb-0eb3c650dce6
  Date: Mon, 28 Dec 2020 15:41:12 GMT
  

This repository should be deprecated after merged PR. just reference to README for checking Python recommendations in development

@NubeDev @RaiBnod @Shiny380

• Python recommendations for development. Check dev branch
• Use setting in json format instead of ini file: for strict type and easy update from command line/another tool
• Build to binary execution
• Dockerize
• Develop on any python version > 3.6, production build in 3.9. No required specific python version on edge device