ntia / p528 Goto Github PK

.NET support is currently provided via .NET Framework v4.8. Support for .NET Core, and in particular cross-platform .NET support, would be useful. With the completion of #16 such cross-platform .NET Core should be possible.

The in-force version of Rec P.528 has an upper terminal height limit of 20km. The software implements this as a hard limit and will not execute outside of this bounds (it returns an error). However, various activities are performing work where it would be useful to allow P.528 to operate above 20km with appropriate disclaimers to the user.

Action: relax the upper terminal limit, such that the user gets a warning if they enter a value above 20km stating that they are operating outside the bounds of the Recommendation. However, still allow the software to compute and return a result.

Currently, although the software is written without any platform specific requirements, the repo doesn't contain any build/compile support for non-Windows platforms. Only a Visual Studio project file is included. The addition of a cmake file, with corresponding build instructions, would expand support to other platforms, such as Linux.

Develop a fully supported .NET wrapper that can be built and offered via NuGet packages.

Create a NuGet package manifest file for publishing to GitHub Packages

ReShaper C++ is showing a potential issue ("Both sides of operator are equivalent [misc-redundant-expression]") with this line:

data::NR_Data[i - i]

I think this is a typo and it should read i-1

But the more I look at this code the more I think there is a general issue (could be wrong)

Looking at a test input of

Result res{};
Main(1, 1.5, 1000, 1200, 0.01, &res);

and putting a breakpoint on the NakagamiRice function I think there are cases when the index goes negative (j == 0 so data::P[j - 1] is an issue)

You can better trap this by converting to use std::array or std::vector and running in debug and the debugger traps the issue