nstarke / bootfuzz Goto Github PK

In the function read_keyboard, the registers are popped in the reverse order of how they were pushed, is that intentional?

Here is how the corrected function should look with the right push and pop order for preserving the register values correctly:

read_keyboard:
    push bx
    push cx
    push dx
    push si
    push di
    mov ah, 0x0
    int 0x16
    pop di
    pop si
    pop dx
    pop cx
    pop bx
    ret

The "in ax,dx" instruction has just one input operand. Pre-populating the value of ax is meaningless, because it will be overwritten by the instruction. Should speed up fuzzing quite a lot.