nrel / wind-hybrid-open-controller Goto Github PK

So that WHOC can communicate with a zeroMQ-based ROSCO agent by sending helics commands (i.e., WHOC does not need to import both helics and zeroMQ)

There is currently some documentation on some of the examples, but this needs to be expanded.

Either:

• Add a description of each example, following the format of the ones currently listed, and ideally including some figures
• Have some form of automatically-generated list of examples, as there is in FLORIS

Of these, I think the former is likely easier since running WHOC/Hercules examples automatically could be tricky

Recent changes to Hercules changed the name of the stand-in version of AMR-Wind from "dummy AMR-Wind" to "AMR-Wind standin". The code in the simple_yaw_control_amrstandin example should be updated to reflect this.

As it stands, example does not run.

As noted in #31 , there are currently dependency conflicts between FLASC and FLORIS. The only reason that FLASC is required in WHOC is for the LookupBasedWakeSteeringController.

Possible solutions:

• Disable the LookupBasedWakeSteeringController and remove FLASC dependencies (#31 ); then reinstate them when FLASC has been brought up to speed with Floris v4
• Implement a local solution for get_yaw_angles_interpolant, which is the only functionality imported from FLASC, and make the removal of the dependency on FLASC permanent.

Add tests for controller base and interfaces, as not done in #10

Improve dependencies to use compatible release specifier such that the dependencies won't go up a major version unless intentionally changed in an update to this repo. This is to avoid breaks due to API changes. Info on compatible release specifier:

https://packaging.python.org/en/latest/specifications/version-specifiers/#id4

Use controls implemented in A2E2G

Following the chosen conventions of FLORIS and FLASC, include into Hercules (when it is a good time, no rush), ruff linting, formatting and pre-commit hooks

Placeholders exist for most, but would like to bulk them out.

Wind speeds and yaw angles would be helpful. Note that while the control actions are yaw set points, and for a floris interface only yaw offsets are stored, that yaw offsets computed based on current wind directions will differ from the yaw offsets set for the last time step's wind directions.

As is done in FLORIS, etc.

Test that this can be used to send and receive signals from two or more separate ROSCO instances.

Depending on ROSCO implementation, may not need to spawn its own server; can simply inherit from ROSCO's base server class.

Implement a wake steering controller and provide example usage on FLORIS standin in Hercules