nre-learning / nre-blog Goto Github PK

Thinking it might be useful to have the promoted lessons carousel on one of the main blog, kind of like the advisor widget.

In looking at this, I noticed the import for the advisor in https://github.com/nre-learning/nre-hugo-theme/blob/master/layouts/partials/scripts.html#L4 was using an older version of the antidote.js file while it was still in antidote-web, before being moved to antidote-ui-components. So I updated it, and also added a reference for the promoted lessons component.

Doing so made it so that neither component worked, because they couldn't get a handle on lit-html:

TypeError: Error resolving module specifier: lit-html

It turns out that the older version of antidote.js that's currently referenced in that repo uses an external, absolute URL for importing lit-html. However, the advisor.js and promotedlessons.js that are currently in master for antidote-ui-components are using it by name, which implies that it has some way of looking it up when running locally, but external web applications can't make use of this so they fail to find it.

Need to research how these imports actually work and how best to move forward. I was considering turning those imports in antidote-ui-components into relative imports but it felt wrong. Anyways I'm putting a hold on this until I have time to do more research.

This will require coordination across the antidote-ui-components, nre-hugo-theme, and this repo.

I was browsing the new website and I noticed on mobile that the layout wasn't right on first page load. The mobile menu is visible and has horizontal scroll, this seems to be resolved if you open and close the menu.

I have attached a video of the issue.

adjust from the hunchback story as cool as that is

In #60 I commented out the front-page advisor component, since it doesn't currently work. This gives a pretty bad first impression to new users, so I'd rather they not see it until it works properly.

#28 highlights that this component uses a very old version of the antidote.js script via a commit ID in antidote-web, and it's possible that in solving that issue, this may be solved as well.

There have been CORS issues for a long time. On chrome in incognito, it seems this was intermittent originally. However, in FF these days this seems more pronounced.

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://go.nrelabs.io/syringe/exp/lesson. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing).

The other main issue is that this uses the old /syringe path, which is another artifact of using an old version of antidote-web.

Once #28 is fixed, we should re-enable this and ensure no CORS issues remain.

• Use cases page, with illustrations. What you can do, and what you could get out of it-
  Contribute to NRE Labs curriculum. We host your content for free.
• logos on front page for involved companies (juniper, red hat, cumulus, extreme)
• Need to build a video for prospective contributing companies. How NRE Labs or any of the subprojects could be useful to them. What they would get out of contributing.

Currently there are very few links anywhere to the collections page.